Closed Bug 1467790 Opened 6 years ago Closed 6 years ago

Inline nsINode::IsEditable

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch inline_is_editable.diff (obsolete) — Splinter Review
Surprisingly, based on profiling a nightly build, compiler doesn't seem to always inline the method. And the method is called in very hot code paths.
We don't have a nice place for nsINode inlines, but the ones we have live in
nsIContentInlines.h
Attachment #8984433 - Flags: review?(masayuki)
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=99ed393962baa5c5c3562672b9641e9326124046
remote: recorded changegroup in replication log in 0.099s
Comment on attachment 8984433 [details] [diff] [review]
inline_is_editable.diff

Wow...
Attachment #8984433 - Flags: review?(masayuki) → review+
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/2d7355e34a983e10fd40bf3e03500ae2bb277787
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d7355e34a983e10fd40bf3e03500ae2bb277787
remote: recorded changegroup in replication log in 0.096s
Attachment #8984433 - Attachment is obsolete: true
Attachment #8984438 - Flags: review?(masayuki)
Attachment #8984438 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/da935e9b476d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: