Closed Bug 1467794 Opened 2 years ago Closed 2 years ago

Split TextEditor::DeleteSelectionAsAction() for internal use

Categories

(Core :: DOM: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

For bug 1465702, we need to distinguish whether TextEditor::DeleteSelectionAsAction() is called for root of edit action or a part of edit action.

So, perhaps, we need to split is implementation to DeleteSelectionInternal() or something.
Priority: -- → P3
Comment on attachment 8989259 [details]
Bug 1467794 - Split TextEditor::DeleteSelectionAsAction() to itself and TextEditor::DeleteSelectionAsSubAction()

https://reviewboard.mozilla.org/r/254314/#review261482
Attachment #8989259 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/7efe662a874d
Split TextEditor::DeleteSelectionAsAction() to itself and TextEditor::DeleteSelectionAsSubAction() r=m_kato
https://hg.mozilla.org/mozilla-central/rev/7efe662a874d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.