1467802 - Split TextEditor::OutputToString() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7f0c9dd89ac918747471227e9a2907213da43cc

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1467802 - part 1: Create TextEditor::WrapWidth() for internal use of nsIPlaintextEditor::GetWrapWidth()

Let's create non-virtual and simple accessor for TextEditor::mWrapColumn.

Review commit: https://reviewboard.mozilla.org/r/257778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257778/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1467802 - part 2: Mark TextEditor::GetAndInitDocEncoder() as const

TextEditor::GetAndInitDocEncoder() modifies only mCachedDocumentEncoder and
mCachedDocumentEncoderType which are cache of the method to save recreation
cost of document encoder when same type document encoder is requested.

So, with marking them mutable, we can change the method to a const method.

Review commit: https://reviewboard.mozilla.org/r/257780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257780/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1467802 - part 3: Create EditorBase::GetDocumentCharsetInternal() for internal use of nsIEditor::GetDocumentCharacterSet()

This patch creates non-virtual method, EditorBase::GetDocumentCharsetInternal(),
for internal use of nsIEditor::GetDocumentCharacterSet() since the virtual
call method is redundant and the caller cannot be marked as const.

Review commit: https://reviewboard.mozilla.org/r/257782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257782/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1467802 - part 4: Create TextEditor::ComputeValueInternal() for internal use of nsIPlaintextEditor::OutputToString()

For reducing virtual calls of nsIPlaintextEditor::OutputToString(),
TextEditor should have new non-virtual public method, ComputeTextValue() and
shared code between it and OutputToString() as ComputeValueInternal().

Review commit: https://reviewboard.mozilla.org/r/257784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257784/

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8993206 [details]
Bug 1467802 - part 1: Create TextEditor::WrapWidth() for internal use of nsIPlaintextEditor::GetWrapWidth()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257778/diff/1-2/

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8993207 [details]
Bug 1467802 - part 2: Mark TextEditor::GetAndInitDocEncoder() as const

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257780/diff/1-2/

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8993208 [details]
Bug 1467802 - part 3: Create EditorBase::GetDocumentCharsetInternal() for internal use of nsIEditor::GetDocumentCharacterSet()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257782/diff/1-2/

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8993209 [details]
Bug 1467802 - part 4: Create TextEditor::ComputeValueInternal() for internal use of nsIPlaintextEditor::OutputToString()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257784/diff/1-2/

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8993206 [details]
Bug 1467802 - part 1: Create TextEditor::WrapWidth() for internal use of nsIPlaintextEditor::GetWrapWidth()

https://reviewboard.mozilla.org/r/257778/#review265304

Comment 11

[Makoto Kato [:m_kato]]

Comment on attachment 8993207 [details]
Bug 1467802 - part 2: Mark TextEditor::GetAndInitDocEncoder() as const

https://reviewboard.mozilla.org/r/257780/#review265316

Comment 12

[Makoto Kato [:m_kato]]

Comment on attachment 8993208 [details]
Bug 1467802 - part 3: Create EditorBase::GetDocumentCharsetInternal() for internal use of nsIEditor::GetDocumentCharacterSet()

https://reviewboard.mozilla.org/r/257782/#review265320

Comment 13

[Makoto Kato [:m_kato]]

Comment on attachment 8993209 [details]
Bug 1467802 - part 4: Create TextEditor::ComputeValueInternal() for internal use of nsIPlaintextEditor::OutputToString()

https://reviewboard.mozilla.org/r/257784/#review265324

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe18ea0d75e2
part 1: Create TextEditor::WrapWidth() for internal use of nsIPlaintextEditor::GetWrapWidth() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c4f14b9849d8
part 2: Mark TextEditor::GetAndInitDocEncoder() as const r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3348025c8857
part 3: Create EditorBase::GetDocumentCharsetInternal() for internal use of nsIEditor::GetDocumentCharacterSet() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/47f713574cb2
part 4: Create TextEditor::ComputeValueInternal() for internal use of nsIPlaintextEditor::OutputToString() r=m_kato

Comment 15

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/fe18ea0d75e2
https://hg.mozilla.org/mozilla-central/rev/c4f14b9849d8
https://hg.mozilla.org/mozilla-central/rev/3348025c8857
https://hg.mozilla.org/mozilla-central/rev/47f713574cb2