Closed Bug 1467803 Opened Last year Closed Last year

Turn off static constructors perf tests for ASan builds

Categories

(Tree Management :: Perfherder, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: igoldan, Assigned: igoldan)

References

Details

Attachments

(1 file)

These are the compiler_metrics num_static_constructors tests.

Requirement originated from https://bugzilla.mozilla.org/show_bug.cgi?id=1443077#c17
Comment on attachment 8984827 [details]
Bug 1467803 - Turn off static ctors perf tests for ASan builds

https://reviewboard.mozilla.org/r/250634/#review256904

::: toolkit/crashreporter/tools/symbolstore.py:642
(Diff revision 1)
> +            for opt in perfherder_extra_options.split():
>                  for suite in perfherder_data['suites']:
>                      if opt not in suite.get('extraOptions', []):
>                          suite.setdefault('extraOptions', []).append(opt)
>  
> +            if platform.system() != 'Linux' or 'asan' not in perfherder_extra_options.lower():

I don't understand this.  Could we not just say:
if 'asan' not in perfherder_extra_options.lower():
   ...
   
   
?
Attachment #8984827 - Flags: review?(jmaher) → review-
Comment on attachment 8984827 [details]
Bug 1467803 - Turn off static ctors perf tests for ASan builds

https://reviewboard.mozilla.org/r/250634/#review256972

thanks for the update
Attachment #8984827 - Flags: review?(jmaher) → review+
Pushed by igoldan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3b724976427
Turn off static ctors perf tests for ASan builds r=jmaher
https://hg.mozilla.org/mozilla-central/rev/f3b724976427
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.