1467803 - Turn off static constructors perf tests for ASan builds

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Ionuț Goldan [:igoldan]]

These are the compiler_metrics num_static_constructors tests.

Requirement originated from https://bugzilla.mozilla.org/show_bug.cgi?id=1443077#c17

Comment 1

[Ionuț Goldan [:igoldan]]

Attachment: Bug 1467803 - Turn off static ctors perf tests for ASan builds

Review commit: https://reviewboard.mozilla.org/r/250634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250634/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8984827 [details]
Bug 1467803 - Turn off static ctors perf tests for ASan builds

https://reviewboard.mozilla.org/r/250634/#review256904

::: toolkit/crashreporter/tools/symbolstore.py:642
(Diff revision 1)
> +            for opt in perfherder_extra_options.split():
>                  for suite in perfherder_data['suites']:
>                      if opt not in suite.get('extraOptions', []):
>                          suite.setdefault('extraOptions', []).append(opt)
>  
> +            if platform.system() != 'Linux' or 'asan' not in perfherder_extra_options.lower():

I don't understand this.  Could we not just say:
if 'asan' not in perfherder_extra_options.lower():
   ...
   
   
?

Comment 3

[Ionuț Goldan [:igoldan]]

Comment on attachment 8984827 [details]
Bug 1467803 - Turn off static ctors perf tests for ASan builds

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250634/diff/1-2/

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8984827 [details]
Bug 1467803 - Turn off static ctors perf tests for ASan builds

https://reviewboard.mozilla.org/r/250634/#review256972

thanks for the update

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3b724976427
Turn off static ctors perf tests for ASan builds r=jmaher

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f3b724976427