1467813 - Various font differences between the First Run page and "about:welcome"

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: font differences between the pages.png

[Affected versions]:
- Nightly 62.0a1 Build ID 20180607220114

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the Browser and navigate to the about:welcome page.
2. Compare the text fonts from the page with the ones from the First Run page (https://www.mozilla.org/en-US/firefox/60.0.2/firstrun/).

[Expected results]:
- No font differences can be observed.

[Actual results]:
- Almost all text is styled differently.

[Notes]:
- Attached a screenshot of the issue.

Comment 1

[Erica Wright [:ewright]]

The currently used font in the moz.org firstrun experience is fira sans. We don't want to fetch a web font from this in-product experience, so we would need to bring the font in-product. I believe there were some concerns with this - one of the reasons was for localization, that this font wouldn't have enough characters. I will however try to fix some small visual differences with the font on about:welcome not appearing bold enough.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4203

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/20fefec583c03c296762308fbf5969b4f24dab94
Bug 1467813 - Make fonts bolder.

https://github.com/mozilla/activity-stream/commit/a17bd5b04d9cc445ecd093f19f1135d7c82b9c75
Merge pull request #4203 from ericawright/font

Fix Bug 1467813 - Various font differences between the First Run page and about:welcome

Comment 4

[Erica Wright [:ewright]]

perhaps we should re-open this for discussion about the actual font family difference...

Comment 5

[Ed Lee :Mardak]

Followups should be separate bugs

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/b9cec1a0e9b5

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly (Build ID 20180625100047) on Windows 10 x64, Mac 10.13.4 and Arch Linux x64. Some strings have been bold in order to resemble the version from release.