1467856 - Add a HasDeviceTouchScreen=0/1 field to crash reports

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[(no longer active)]

It would be nice if crash reports had a bit set on them to tell us whether the device has a touch screen or not.  Then the correlation detection scripts could have told us for example that bug 1462742 corresponds 100% to HasDeviceTouchScreen=1.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ehsan: Where is that information in the crash report?

Comment 2

[(no longer active)]

It doesn't exist right now, it needs to be added, perhaps as an annotation or however it's easiest to consume on the Socorro side...

Sorry I wasn't specific about that part, I do expect us to need to file a dependency bug about that on the Gecko side to add the information to crash reports.  It would be nice if you or someone familiar with the Socorro side of things could add some information on what format would be most suitable for this data, and note any specific requirements we should keep in mind when adding the information to the crash reports.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

No problem!

If it's in the crash report, that's easy to pull out and index. 0 and 1 are easy values to do something with. We'd probably turn them into True and False. We get a lot of values this way like 

If you want to do stuff with this value in the telemetry data, then we can extract it from the TelemetryEnvironment.

Does that help?

Comment 4

[(no longer active)]

Yes, thank you!

Comment 5

[(no longer active)]

I just landed bug 1468612 on inbound, hopefully that's sufficient from the Gecko side.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2 so it's in the queue.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Here's an example crash with the item in the raw crash:

https://crash-stats.mozilla.com/report/index/9e8dfd94-774b-4bb0-b2cc-a12950180912#tab-metadata

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4591: fix bug 1490662, 1420797, 1467856: add fields to super search

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/da3fc74838564df4a06490dde83422357ee797df
fix bug 1467856: add has_device_touch_screen to super search

https://github.com/mozilla-services/socorro/commit/39964ca7144f28c177928a80b07e6f798f137229
Merge pull request #4591 from willkg/1490662-memoryerrorcorrection

fix bug 1490662, 1420797, 1467856: add fields to super search

Comment 10

[(no longer active)]

Thank you!