1467861 - [wpt-sync] Sync PR 11420 - CSS Typed OM: Proper types for custom props during iteration.

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11420 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11420
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:
>  CSS Typed OM: Proper types for custom props during iteration.
>  
>  Currently, you get CSSUnparsedValues when iterating entries on the
>  .computedStyleMap(), even for properties which are registered with a
>  type. However, if you do .computedStyleMap().get(...) with a registered
>  property, you _do_ get the correct type.
>  
>  This is because ComputedStyleCSSValueMapping::Get properly looks up the
>  typed values on the ComputedStyle, but ::GetVariables does not; instead it
>  directly returns the CSSVariableData for everything, regardless of
>  registrations.
>  
>  This patch changes the behavior of iteration to use the same code path
>  as .get(). This ensures that we either create a CSSCustomProperty-
>  Declaration on the fly for unregistered properties, or we re-use the
>  existing (and typed) CSSValue for registered properties.
>  
>  Note: I initially wanted to do a nested iterator thing here, but dropped
>        it because we would anyway need a temp HashSet to avoid potential
>        duplicates from the StyleInheritedVariables-root.
>  
>  Note: One caller of GetVariables() just wants the size. It's possibly a
>        little overkill to create entire HashMap just to count something,
>        but I don't want to resolve that here in the same patch.
>  
>  R=[e-mail], [e-mail]
>  
>  Bug: 850072
>  Change-Id: I64bfb3cc22a377cf956420a9e64d47ca3daac1e2
>  Reviewed-on: https://chromium-review.googlesource.com/1090848
>  Reviewed-by: Rune Lillesveen <[e-mail]>
>  Commit-Queue: Anders Ruud <[e-mail]>
>  Cr-Commit-Position: refs/heads/master@{#565605}
>

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3753a3e2a9325b42deb10067ee0e9a9891756e59

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=99f5caf00ab3cc8ed1f530a7f7d9cbdd28d078ac

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 5 subtests
OK     : 1
PASS   : 5

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84a6bcf40bef
[wpt PR 11420] - CSS Typed OM: Proper types for custom props during iteration., a=testonly

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/84a6bcf40bef