Closed Bug 1467868 Opened Last year Closed 11 months ago

Add AArch64 Debug builds of Fennec and GV

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set

Tracking

(geckoview64 wontfix, firefox64 wontfix, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
geckoview64 --- wontfix
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: bc, Assigned: gbrown)

References

(Blocks 1 open bug)

Details

(Whiteboard: [geckoview:p1][arm64:m1])

Attachments

(2 files)

We added 64bit opt builds in Bug 1366404 - Add AArch64 Nightly builds.

I think we would like to begin testing on android hardware using debug builds as well.
Blocks: Fennec-ARM64
Summary: Add AArch64 Debug Nightly builds → Add AArch64 Debug Nightly builds of Fennec and GV
Whiteboard: [geckoview]
Priority: -- → P1
Summary: Add AArch64 Debug Nightly builds of Fennec and GV → Add AArch64 Debug builds of Fennec and GV
Depends on: 1366404
Priority: P1 → --
See Also: 1366404
Whiteboard: [geckoview] → [geckoview:p1]
Whiteboard: [geckoview:p1] → [geckoview:p1][arm64:m1]
Who would own this bug?
Flags: needinfo?(bob)
jchen did the original work for aarch64 in Bug 1366404. I don't know who else on the mobile team might be up for it. It might be possible to leverage the work jchen did and not have to reinvent the wheel here. snorp, do you have any thoughts about this?
Flags: needinfo?(bob) → needinfo?(snorp)
(In reply to Bob Clary [:bc:] from comment #2)
> jchen did the original work for aarch64 in Bug 1366404. I don't know who
> else on the mobile team might be up for it. It might be possible to leverage
> the work jchen did and not have to reinvent the wheel here. snorp, do you
> have any thoughts about this?

Is there anything we need to do right now? If stuff is busted under debug we can just prioritize those issues as they come in.
Flags: needinfo?(snorp)
Not that I know of but since we don't generate the builds we don't test them. If I have time, I'll try to run tests locally and see what's up.
(In reply to Bob Clary [:bc:] from comment #4)
> Not that I know of but since we don't generate the builds we don't test
> them. If I have time, I'll try to run tests locally and see what's up.

Oh, generating the builds should be trivial, I'd think? Maybe gbrown can wrangle the taskcluster jobs?
Flags: needinfo?(gbrown)
Assignee: nobody → gbrown
Flags: needinfo?(gbrown)
There is no support for aarch64 artifact builds. Does anyone know why? Should I worry about it?
(In reply to Geoff Brown [:gbrown] from comment #7)
> There is no support for aarch64 artifact builds. Does anyone know why?
> Should I worry about it?

Nah, nothing to worry about.  It just requires another mozconfig and a little tweaking in artifacts.py.  If you want to add it, please do (I'd prefer we support artifact builds everywhere).
See Also: → 1510612
I have not worked in this area before and don't know what I'm doing...but copy-and-paste of prior art appears to produce an appropriate build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c99f309c24efef19f911b3541fcbc62ed00a529
Attachment #9028419 - Flags: review?(nalexander)
Comment on attachment 9028419 [details] [diff] [review]
add Android aarch64 debug builds

Review of attachment 9028419 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, that's basically that.  Consider folding this and the next, since the artifact bit is dangling in the interim.
Attachment #9028419 - Flags: review?(nalexander) → review+
Comment on attachment 9028420 [details] [diff] [review]
add Android aarch64 artifact builds

Review of attachment 9028420 [details] [diff] [review]:
-----------------------------------------------------------------

Could you also add to the table around here: https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/python/mozbuild/mozbuild/artifacts.py#539

No need for re-review.  Thanks for jumping in!
Attachment #9028420 - Flags: review?(nalexander) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f005cfb0b0fa
Add Android aarch64/debug build; r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/09acef99bf7e
Support Android aarch64 artifact builds; r=nalexander
https://hg.mozilla.org/mozilla-central/rev/f005cfb0b0fa
https://hg.mozilla.org/mozilla-central/rev/09acef99bf7e
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
status-geckoview64=wontfix
QA Contact: mirabela.lobontiu
Depends on: 1512408
Depends on: 1512579
Depends on: 1512583
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.