1467868 - Add AArch64 Debug builds of Fennec and GV

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Bob Clary [:bc] (inactive)]

We added 64bit opt builds in Bug 1366404 - Add AArch64 Nightly builds.

I think we would like to begin testing on android hardware using debug builds as well.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Who would own this bug?

Comment 2

[Bob Clary [:bc] (inactive)]

jchen did the original work for aarch64 in Bug 1366404. I don't know who else on the mobile team might be up for it. It might be possible to leverage the work jchen did and not have to reinvent the wheel here. snorp, do you have any thoughts about this?

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Bob Clary [:bc:] from comment #2)
> jchen did the original work for aarch64 in Bug 1366404. I don't know who
> else on the mobile team might be up for it. It might be possible to leverage
> the work jchen did and not have to reinvent the wheel here. snorp, do you
> have any thoughts about this?

Is there anything we need to do right now? If stuff is busted under debug we can just prioritize those issues as they come in.

Comment 4

[Bob Clary [:bc] (inactive)]

Not that I know of but since we don't generate the builds we don't test them. If I have time, I'll try to run tests locally and see what's up.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Bob Clary [:bc:] from comment #4)
> Not that I know of but since we don't generate the builds we don't test
> them. If I have time, I'll try to run tests locally and see what's up.

Oh, generating the builds should be trivial, I'd think? Maybe gbrown can wrangle the taskcluster jobs?

Comment 6

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c99f309c24efef19f911b3541fcbc62ed00a529

Comment 7

[Geoff Brown [:gbrown]]

There is no support for aarch64 artifact builds. Does anyone know why? Should I worry about it?

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Geoff Brown [:gbrown] from comment #7)
> There is no support for aarch64 artifact builds. Does anyone know why?
> Should I worry about it?

Nah, nothing to worry about.  It just requires another mozconfig and a little tweaking in artifacts.py.  If you want to add it, please do (I'd prefer we support artifact builds everywhere).

Comment 9

[Geoff Brown [:gbrown]]

Attachment: add Android aarch64 debug builds

I have not worked in this area before and don't know what I'm doing...but copy-and-paste of prior art appears to produce an appropriate build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c99f309c24efef19f911b3541fcbc62ed00a529

Comment 10

[Geoff Brown [:gbrown]]

Attachment: add Android aarch64 artifact builds

I managed to add artifact builds also:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fac29dd744a7cc9888eb77b2345f096b6ce56a1d

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 9028419 [details] [diff] [review]
add Android aarch64 debug builds

Review of attachment 9028419 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, that's basically that.  Consider folding this and the next, since the artifact bit is dangling in the interim.

Comment 12

[Nick Alexander :nalexander [he/him]]

Comment on attachment 9028420 [details] [diff] [review]
add Android aarch64 artifact builds

Review of attachment 9028420 [details] [diff] [review]:
-----------------------------------------------------------------

Could you also add to the table around here: https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/python/mozbuild/mozbuild/artifacts.py#539

No need for re-review.  Thanks for jumping in!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f005cfb0b0fa
Add Android aarch64/debug build; r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/09acef99bf7e
Support Android aarch64 artifact builds; r=nalexander

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f005cfb0b0fa
https://hg.mozilla.org/mozilla-central/rev/09acef99bf7e

Comment 15

[Chris Peterson [:cpeterson]]

status-geckoview64=wontfix