Closed Bug 1467883 Opened 7 years ago Closed 7 years ago

Reviewer didn't get flagged for review in bugzilla upon submitting of changeset via `arc diff`

Categories

(Conduit :: Phabricator, enhancement)

Product:
Conduit
Component:
Phabricator
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: kats, Assigned: dkl)

Details

I just submitted a patch using `arc diff` to bug 1467867. The differential thingy is at https://phabricator.services.mozilla.com/D1599 In phabricator it seems to recognize that botond is the reviewer, but on the bug it didn't flag botond for review.
Currently this is by design. Phabricator will not set the flag on the bug's attachment until the review is accepted (r+). We originally wanted the review process to stay within Phabricator and not rely on Bugzilla for people to manage their review load. So we just set r+ for record keeping. If a user in Phabricator denies a review and asks for changes we also do not set r- we just remove the r+ of it was previously given. This workflow may change in the future as we get more feedback but for now this is proper behavior. Thanks dkl
Assignee: nobody → dkl
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.