Closed Bug 1467914 Opened Last year Closed 11 months ago

Frequent LSan DNS leaks in WPT tests

Categories

(Core :: Networking: DNS, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mccr8, Assigned: valentin.gosu)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

Attached file leak.txt
Bug 1354232 is about getting WPT tests working with LSan. The most common leaks that seem to show up involve DNS. The leak seems to involve a NetAddrElement, an AddrInfo, and an mHostName string. See the attached file for stacks. This has also showed up for our existing tests, in bug 1400161, but not as frequently. I'm not sure why that is.
See Also: → 1400161
We've also got some issues in bug 1423945 that might fix this.
Assignee: nobody → valentin.gosu
Priority: -- → P2
Whiteboard: [necko-triaged]
Andrew, do the leaks still happen?
(In reply to Valentin Gosu [:valentin] from comment #2)
> Andrew, do the leaks still happen?
Flags: needinfo?(continuation)
You need to remove the DNS-related entries from https://searchfox.org/mozilla-central/source/testing/web-platform/meta/__dir__.ini#1 and do a try run (or otherwide run the tests in an asan build) to find out (or you can examine the log files from an exisitng  run for EXPECTED-FAIL with those entries).
Thanks! I'll check!
Flags: needinfo?(continuation)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/32e2b80f6555
Remove expected fails for DNS LSan in WPT r=mccr8
This started to fail on autoaland.
I've created a new bug for this wpt7 failures.
Please take a look.
Flags: needinfo?(valentin.gosu)
Thanks for filing a separate bug. I think this is due to me removing the Init from the method list. It seems that was suppressing a bunch of other leaks. I'll try to handle it in bug 1497947.
Flags: needinfo?(valentin.gosu)
https://hg.mozilla.org/mozilla-central/rev/32e2b80f6555
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
See Also: → 1497947
You need to log in before you can comment on or make changes to this bug.