Closed Bug 1467918 Opened 2 years ago Closed 2 years ago

Make apz_test_utils.js work with GeckoView

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Right now it uses Services.wm.getMostRecentWindow('navigator:browser') in a couple places, but GeckoView uses navigator:geckoview.
Comment on attachment 8984606 [details]
Bug 1467918 - Fix APZ utils to work with GeckoView

https://reviewboard.mozilla.org/r/250484/#review256764

Seems a bit hacky, but since it's just test code, it's fine.

::: commit-message-028db:1
(Diff revision 1)
> +Bug 1467918 - Fix APZ utils to work with GeckoView r=botond

"APZ utils" -> "APZ test utils"
Attachment #8984606 - Flags: review?(botond) → review+
Is this good to land?
Assignee: nobody → snorp
Flags: needinfo?(snorp)
Priority: -- → P3
Whiteboard: [gfx-noted]
It is, modulo the commit message. I was on PTO last week but will try to land this today.
Flags: needinfo?(snorp)
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7230ab18e62
Fix APZ test utils to work with GeckoView r=botond
https://hg.mozilla.org/mozilla-central/rev/b7230ab18e62
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.