Closed Bug 1467921 Opened 2 years ago Closed 2 years ago

Disable Web Push

Categories

(GeckoView :: General, enhancement, P1)

59 Branch
Unspecified
Android
enhancement

Tracking

(firefox61 wontfix, firefox62 fixed, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It doesn't work right now and causes hangs if you try to use it.
Comment on attachment 8984608 [details]
Bug 1467921 - Disable Web Push in GeckoView

https://reviewboard.mozilla.org/r/250492/#review256940
Attachment #8984608 - Flags: review?(nchen) → review+
Assigning this bug to James because he's already working on it.
Assignee: nobody → snorp
OS: Unspecified → Android
Priority: -- → P1
Flags: needinfo?(snorp)
https://hg.mozilla.org/mozilla-central/rev/8bf2b990c788
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
James is this something we should uplift to beta or can we just let it ride the trains?
Flags: needinfo?(snorp)
We need to uplift.
Flags: needinfo?(snorp)
Comment on attachment 8984608 [details]
Bug 1467921 - Disable Web Push in GeckoView

Approval Request Comment
[Feature/Bug causing the regression]: GeckoView
[User impact if declined]: Hangs in GeckoView
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: There isn't really a Nightly
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1467919
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only changes a pref for GeckoView
[String changes made/needed]: None
Attachment #8984608 - Flags: approval-mozilla-beta?
Can you request uplift in bug 1467919 too? Thanks!
Flags: needinfo?(snorp)
Comment on attachment 8984608 [details]
Bug 1467921 - Disable Web Push in GeckoView

Should only affect GeckoView, let's uplift for beta 7.
Attachment #8984608 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(snorp)
Product: Firefox for Android → GeckoView
Version: Firefox 59 → 59 Branch
Target Milestone: Firefox 63 → mozilla63
You need to log in before you can comment on or make changes to this bug.