Closed Bug 1467929 Opened 2 years ago Closed Last year

Disable collection of Browser JS Errors on old nightly builds

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: osmose, Assigned: osmose)

References

Details

Attachments

(1 file)

Telemetry analysis shows that 13%-40% of browser JS errors sent to Sentry per-day are from builds of Firefox that are over a week old. Since Nightly updates twice per-day with the latest code from Mozilla, we're assuming that errors from weeks-old code aren't as relevant as errors from more recent builds, and can be safely discarded.

To help with the issue of ratelimiting (bug 1464138), we should disable reporting for builds of Firefox that are older than a week.
Comment on attachment 8985117 [details]
Bug 1467929: Only collect browser JS errors from recent builds.

https://reviewboard.mozilla.org/r/250826/#review257046

Nice!

::: browser/modules/BrowserErrorReporter.jsm:90
(Diff revision 1)
>   */
>  class BrowserErrorReporter {
> +  /**
> +   * Generate a Date object corresponding to the date in the appBuildId.
> +   */
> +  static appBuildIdDate() {

Can we define this as a lazy getter? After all, it'll never change...
Attachment #8985117 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mkelly@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f338645c1e20
Only collect browser JS errors from recent builds. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/f338645c1e20
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.