Closed Bug 1467971 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 11446 - [css-contain] Size containment should ignore contents in flexbox/grid

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11446 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11446
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-contain] Size containment should ignore contents in flexbox/grid
>  
>  The spec is pretty clear
>  (https://drafts.csswg.org/css-contain/#containment-size):
>    "1. When laying out the containing element,
>    it must be treated as having no contents."
>  
>  The patch modifies ComputeIntrinsicLogicalWidths() and
>  FirstLineBoxBaseline() in LayoutFlexibleBox and LayoutGrid,
>  so the contents are ignored if the flex or grid container
>  has "contain: size".
>  Buttons are implemented as flexboxes internally,
>  so they get fixed too thanks to this change.
>  
>  BUG=850169
>  TEST=external/wpt/css/css-contain/contain-size-button-001.html
>  TEST=external/wpt/css/css-contain/contain-size-flexbox-001.html
>  TEST=external/wpt/css/css-contain/contain-size-grid-001.html
>  
>  Change-Id: Ia08c2c7b31126911cb4f0d1fc70aa444c22af8e3
>  Reviewed-on: https://chromium-review.googlesource.com/1093854
>  WPT-Export-Revision: 362a8775e389f3195f00ae36a8beb85bae6b9cc2
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 3 tests
FAIL   : 3

New tests that have failures or other problems:
/css/css-contain/contain-size-button-001.html: FAIL
/css/css-contain/contain-size-flexbox-001.html: FAIL
/css/css-contain/contain-size-grid-001.html: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64d8636084f4
[wpt PR 11446] - [css-contain] Size containment should ignore contents in flexbox/grid, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/50747b1f5cd5
[wpt PR 11446] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/64d8636084f4
https://hg.mozilla.org/mozilla-central/rev/50747b1f5cd5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.