Closed Bug 1468060 Opened Last year Closed Last year

No disabled styling for toolbaritem-combined-buttons in appMenu-popup

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: magicp.jp, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

Steps to reproduce:
1. Start Nightly
2. Go to about:preferences
3. Open menu

Actual results:
Cut, copy and paste buttons are not disabled styling even if disabled state.

Expected results:
Apply disabled styling.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b523c89c3497596fab20cda825115daa5b0b7ac4&tochange=1c7d89955364c87b891157ffdde74be8c3ea74cc
Blocks: 1466306
Has Regression Range: --- → yes
Has STR: --- → yes
Dao, is this expected, given Bug 1466306?
Flags: needinfo?(dao+bmo)
Nope, not expected.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo)
Priority: -- → P1
setting to fix-optional for 62, but we would probably take a patch still.
Comment on attachment 8988705 [details]
Bug 1468060 - Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup.

https://reviewboard.mozilla.org/r/253918/#review260684
Attachment #8988705 - Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e738c5c8f5e2
Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup. r=jaws
https://hg.mozilla.org/mozilla-central/rev/e738c5c8f5e2
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Comment on attachment 8988705 [details]
Bug 1468060 - Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1466306
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: this seems trivial enough that it could go ahead without QE verification
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple, isolated fix
[String changes made/needed]: /
Attachment #8988705 - Flags: approval-mozilla-beta?
Comment on attachment 8988705 [details]
Bug 1468060 - Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup.

Minor theme fix for a recent regression, let's take this for beta 6.
Attachment #8988705 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Keywords: checkin-needed
Keywords: checkin-needed
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.