1468060 - No disabled styling for toolbaritem-combined-buttons in appMenu-popup

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[magicp]

Attachment: no-disabled-styling-for-toolbaritem-combined-buttons.png

Steps to reproduce:
1. Start Nightly
2. Go to about:preferences
3. Open menu

Actual results:
Cut, copy and paste buttons are not disabled styling even if disabled state.

Expected results:
Apply disabled styling.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b523c89c3497596fab20cda825115daa5b0b7ac4&tochange=1c7d89955364c87b891157ffdde74be8c3ea74cc

Comment 1

[Mike Taylor [:miketaylr]]

Dao, is this expected, given Bug 1466306?

Comment 2

[Dão Gottwald [:dao]]

Nope, not expected.

Comment 3

[Mike Taylor [:miketaylr]]

setting to fix-optional for 62, but we would probably take a patch still.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1468060 - Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup.

Review commit: https://reviewboard.mozilla.org/r/253918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253918/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8988705 [details]
Bug 1468060 - Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup.

https://reviewboard.mozilla.org/r/253918/#review260684

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e738c5c8f5e2
Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup. r=jaws

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e738c5c8f5e2

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8988705 [details]
Bug 1468060 - Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1466306
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: this seems trivial enough that it could go ahead without QE verification
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple, isolated fix
[String changes made/needed]: /

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8988705 [details]
Bug 1468060 - Fix disabled styling for toolbaritem-combined-buttons in appMenu-popup.

Minor theme fix for a recent regression, let's take this for beta 6.

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8f24de7f709f