1468078 - Cannot remove Space and Flexible Space customisation from Menu Bar 62.0a1 (2018-06-10) (64-bit) (Daily)

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Mark Barnes [:WoofGrrrr]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180605171542

Steps to reproduce:

Right-click on menu bar and select "Customize..."
Drag a space and a flexible space from the Customize Toolbar onto the menu bar
Click done on the Customize Toolbar
Restart Daily
Right-click on menu bar and select "Customize..."
Try to drag either space out of the menu bar


Actual results:

It drags the whole app window

(on Thunderbird, it drags the actual space)


Expected results:

The space should be dragged back to the Customize Toolbar

Comment 1

[Jorg K (CEST = GMT+2)]

Richard, can you please take a look.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug1468078.patch

Probably a fallout of bug 1428938.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8985156 [details] [diff] [review]
Bug1468078.patch

Looks good, I didn't test it, but I'm sure you have ;-)

Comment 4

[Richard Marti (:Paenglab)]

Thanks.

Comment 5

[Jorg K (CEST = GMT+2)]

@Mark: Thank you for using Daily and reporting the issue. Daily can be very bumpy at times. I'm trying to keep it as stable as possible, but currently, as you know, Calendar/Lightning isn't working, so that's a big drawback.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cda0810fda3e
Make the spacer and spring draggable on menu- and tabbar. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

Hmm, this works in TB 60 beta 7, right? I could drag a flexible space off the menu after a restart. So bug 1428938 is not the likely cause since that landed on mozilla59, and we ported in bug 1429861 landed on TB 59.

Can you find where that's gone wrong? On customise we had bug 1448600 and bug 1452199.

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 8985156 [details] [diff] [review]
Bug1468078.patch

This unfortunately didn't land on ESR, see bug 1481943.

Comment 12

[Richard Marti (:Paenglab)]

Jörg, it seems the patch has never reached ESR. Can you land it?

Comment 13

[Jorg K (CEST = GMT+2)]

Yes, because it doesn't have a target :-(

Comment 14

[Jorg K (CEST = GMT+2)]

TB 60.5.2/60.6:
https://hg.mozilla.org/releases/comm-esr60/rev/19ef11233ccebeca7da24ca326162a6cefba5a4e