Closed Bug 1468138 Opened 3 years ago Closed 3 years ago

Throttle box model update call

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

We should throttle updateBoxModel similar to onReflow in the GridInspector since this is called on every reflow.
Comment on attachment 8984789 [details]
Bug 1468138 - Throttle box model update call.

https://reviewboard.mozilla.org/r/250580/#review257074

Can you explain more about the benefits for doing this? Do you have perf profiles that prove that this is better?
I'm not against doing it at all. But right now, reflow events are tracked actor-side, and are already throttled there. See https://searchfox.org/mozilla-central/source/devtools/server/actors/reflow.js#205-217
So I'm wondering if this is really needed.
Attachment #8984789 - Flags: review?(pbrosset)
Ah, I should've known. I was really just looking at how we throttle it in the GridInspector and figured we should do the same here. My only perf benefit is only anecdotal at best since I noticed the CPU always goes up on any reflow with the inspector in use, and figured we are probably doing too much updates on reflow. So, this was an attempt to lessen that load.
Product: Firefox → DevTools
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.