1468138 - Throttle box model update call

Status: RESOLVED WONTFIX

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

We should throttle updateBoxModel similar to onReflow in the GridInspector since this is called on every reflow.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1468138 - Throttle box model update call.

Review commit: https://reviewboard.mozilla.org/r/250580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250580/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8984789 [details]
Bug 1468138 - Throttle box model update call.

https://reviewboard.mozilla.org/r/250580/#review257074

Can you explain more about the benefits for doing this? Do you have perf profiles that prove that this is better?
I'm not against doing it at all. But right now, reflow events are tracked actor-side, and are already throttled there. See https://searchfox.org/mozilla-central/source/devtools/server/actors/reflow.js#205-217
So I'm wondering if this is really needed.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Ah, I should've known. I was really just looking at how we throttle it in the GridInspector and figured we should do the same here. My only perf benefit is only anecdotal at best since I noticed the CPU always goes up on any reflow with the inspector in use, and figured we are probably doing too much updates on reflow. So, this was an attempt to lessen that load.