1468159 - Convert lodash .union() to native ES6 JS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Eliott Vincent [:evct] (GMT+2)]

Converting all _.union() (lodash) functions to ES6 JS

Comment 1

[Eliott Vincent [:evct] (GMT+2)]

Here's what I have in mind to replace _.union() with native ES6:

const c = [2, 3, 3, 4];
const d = [1, 2, 3];
const uniondBis = Array.from(new Set([...c, ...d]));
console.log(uniondBis);
// [ 2, 3, 4, 1 ]

Spreading syntax to merge the arrays.
new Set() to remove duplicates.
Array.from() to convert back to an Array.

Comment 2

[Eliott Vincent [:evct] (GMT+2)]

Finally went with this syntax:

const union = [...new Set([...c, ...d])];

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3655

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8985073 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3655

Awaiting new updates.

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8985073 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3655

Requested updates in the PR.  Clearing review for now.

Comment 6

[Eliott Vincent [:evct] (GMT+2)]

Comment on attachment 8985073 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3655

Request changes done.

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 8985073 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3655

Comments in PR.  Hit an error while testing.

Comment 8

[Cameron Dawson [:camd]]

Actually, this is likely because this branch is based on a commit that had this error.  Would you rebase and try again please?

Comment 9

[Eliott Vincent [:evct] (GMT+2)]

I've rebased on last master and force pushed. As far as I have tested, no error when visiting the Alerts tab.

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/1955db0588134e0de7138af82f06d4446b6a74d8
Bug 1468159 - convert _.union() usages to ES6 (#3655)