Closed
Bug 1468165
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11455 - webrtc wpt: add cleanup to close peerconnections
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream error])
Sync web-platform-tests PR 11455 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11455 Details from upstream follow. Philipp Hancke <philipp.hancke@googlemail.com> wrote: > webrtc wpt: add cleanup to close peerconnections > > adds a pc.close() to all RTCPeerConnections in promise_test > and async_test. This is codemod-powered by this: > https://github.com/fippo/webrtc-codemods/blob/e844b2467cbb76a231c113366b2451cf248f53bc/wpt-rtcpeerconnection-no-helpers > > BUG=836871 > > Change-Id: Iee84ef938bf477a55612b6012c6de464c6aea55b > Reviewed-on: https://chromium-review.googlesource.com/1049983 > Commit-Queue: Henrik Boström <hbos@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565591} >
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ce708a046cb118b2024ca88f42ce8b46beb2fc4
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9850857529fdf9ca0aad1d271f00862f1595b8d7
Assignee | ||
Comment 3•6 years ago
|
||
Ran 49 tests and 287 subtests OK : 45 PASS : 126 FAIL : 158 TIMEOUT: 2 NOTRUN : 2 New tests that have failures or other problems: /webrtc/RTCPeerConnection-setLocalDescription.html onsignalingstatechange fires before setLocalDescription resolves: FAIL Tests that are disabled for instability: /webrtc/RTCDTMFSender-ontonechange.https.html /webrtc/RTCPeerConnection-setRemoteDescription-answer.html /webrtc/RTCPeerConnection-setRemoteDescription-offer.html
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/4692f0774736 [wpt PR 11455] - webrtc wpt: add cleanup to close peerconnections, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a08671b436 [wpt PR 11455] - Update wpt metadata, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/1f8ab1d56b77 [wpt PR 9796] - Update payment-handler IDL file, a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4692f0774736 https://hg.mozilla.org/mozilla-central/rev/e6a08671b436 https://hg.mozilla.org/mozilla-central/rev/1f8ab1d56b77
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•