Closed
Bug 1468186
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 11459 - Fix errors external/wpt/RTCPeerConnection-removeTrack.https.html.
Categories
(Testing :: web-platform-tests, defect, P4)
Testing
web-platform-tests
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream error])
Sync web-platform-tests PR 11459 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/11459
Details from upstream follow.
Henrik Boström <hbos@chromium.org> wrote:
> Fix errors external/wpt/RTCPeerConnection-removeTrack.https.html.
>
> This is in preparation for RTCRtpTransceiver/Unified Plan support.
>
> "Calling removeTrack with valid sender should set sender.track to null"
> Asserting that direction changes from 'sendrecv' to 'recvonly', this
> is explicit in the spec[1].
>
> "Calling removeTrack with currentDirection blah should set direction to
> blah"
> The tests that meant to set up currentDirection to be 'sendrecv' or
> 'recvonly' before removeTrack() were incorrect. Tests updated to set
> up currentDirection correctly. Also updated them to use async/await
> because that's much nicer.
>
> These all fail because we don't have transceivers yet, but when running
> these changes in the RTCRtpTransceiver WIP CL[2], they all pass.
>
> [1] See step 10 of
> https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-removetrack
> [2] https://chromium-review.googlesource.com/c/chromium/src/+/1025771/
>
> Bug: 777617
> Change-Id: Ie3c077d14ea30038a06a98ecbeea475ac824dd9c
> Reviewed-on: https://chromium-review.googlesource.com/1095275
> WPT-Export-Revision: d9dbd506f9e2c9c554f0c895ed9c51997895323a
Assignee | ||
Updated•7 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/986d9d5e1ea3
[wpt PR 11459] - Fix errors external/wpt/RTCPeerConnection-removeTrack.https.html., a=testonly
Comment 2•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•