Closed Bug 1468198 Opened Last year Closed Last year

Remove tests that only run on B2G

Categories

(Testing :: Marionette, enhancement, P1)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

Details

Attachments

(1 file)

there are 2 directories of tests:
https://searchfox.org/mozilla-central/search?q=b2g&path=*.ini

that appear to only run on b2g.  We should remove these tests and related manifests.
:whimboo- do you know who would be someone to confirm this is ok?
Flags: needinfo?(hskupin)
Check who has written the tests and just inform them that you are about to remove the tests. They won't be able to run anyway given that for Marionette we already removed all the b2g code.
Flags: needinfo?(hskupin)
Have you spoken to the DOM team as it's their marionette tests
Flags: needinfo?(jmaher)
I should have started with querying the test authors, that makes the most sense instead of starting by querying someone who has worked on the marionette harness.  The authors/reviewers of these tests are not active with Mozilla anymore- so I am asking triage owners.

:overholt- can you confirm the removal of the dom:events tests
:jduell- can you confirm the removal of the networking tests
:whimboo- can you confirm the other references to various .ini files and links
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Flags: needinfo?(jmaher)
Attachment #8985074 - Flags: review?(overholt)
Attachment #8985074 - Flags: review?(jduell.mcbugs)
Attachment #8985074 - Flags: review?(hskupin)
Comment on attachment 8985074 [details] [diff] [review]
remove related files for old marionette tests

Review of attachment 8985074 [details] [diff] [review]:
-----------------------------------------------------------------

You will also have to make sure to remove all traces from those two manifest files, which included `testing/marionette/harness/marionette_harness/tests/webapi-tests.ini`, and `testing/marionette/moz.build`.
Attachment #8985074 - Flags: review?(hskupin) → review-
Comment on attachment 8985074 [details] [diff] [review]
remove related files for old marionette tests

r+ for the removal of dom/events stuff
Attachment #8985074 - Flags: review?(overholt) → review+
Priority: -- → P1
Summary: remove tests that only run on b2g → Remove tests that only run on B2G
Comment on attachment 8985074 [details] [diff] [review]
remove related files for old marionette tests

:whimboo- I have already removed all those instances in my original patch, please take a secondary look :)
Attachment #8985074 - Flags: review- → review?(hskupin)
Comment on attachment 8985074 [details] [diff] [review]
remove related files for old marionette tests

Review of attachment 8985074 [details] [diff] [review]:
-----------------------------------------------------------------

That's why I dislike splinter review because you don't see the full path, and with lots of files it gets confusing. So yes, it looks fine.
Attachment #8985074 - Flags: review?(hskupin) → review+
Comment on attachment 8985074 [details] [diff] [review]
remove related files for old marionette tests

:mcmanus- could you review the changes to remove the netwerk related tests?  I haven't heard from :jduell in 2 weeks on this.
Attachment #8985074 - Flags: review?(jduell.mcbugs) → review?(mcmanus)
Attachment #8985074 - Flags: review?(mcmanus) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ea86c82810e
remove tests that only run on b2g. r=smaug,mcmanus,whimboo
https://hg.mozilla.org/mozilla-central/rev/8ea86c82810e
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.