1468199 - remove references to b2g in test manifests

Status: RESOLVED FIXED

(Testing :: General, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

there are 3 manifests which have skip-if conditions related to b2g:
https://searchfox.org/mozilla-central/search?q=skip-if.*b2g&regexp=true&path=*.ini

please remove the b2g clauses and related comments.

Comment 1

[Bogdan Tara[:bogdan_tara | bogdant]]

Attachment: bug_1468199.patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8984927 [details] [diff] [review]
bug_1468199.patch

Review of attachment 8984927 [details] [diff] [review]:
-----------------------------------------------------------------

one small error, the rest looks good.

::: accessible/tests/mochitest/hittest/a11y.ini
@@ -5,4 @@
>  
>  [test_browser.html]
>  [test_canvas_hitregion.html]
> -skip-if = (os == "android" || appname == "b2g")

we need to keep the android clause here, only remove the clause that has b2g.

Comment 3

[Andreea Pavel [:apavel]]

Attachment: redid the patch with required modifications

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8985066 [details] [diff] [review]
redid the patch with required modifications

Review of attachment 8985066 [details] [diff] [review]:
-----------------------------------------------------------------

really close

::: dom/xhr/tests/mochitest.ini
@@ +104,2 @@
>  [test_XHR_timeout.html]
> +skip-if = buildapp == (android_version == '18' && debug) 

buildapp == is not what we want here, just:
skip-if = (android_version == '18' && debug)

nit: please remove the trailing whitespace (at the end of the line)

Comment 5

[Andreea Pavel [:apavel]]

Attachment: Removed old references and extra spaces

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9e5997437dc
remove references to b2g in test manifests r=jmaher

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c9e5997437dc