remove references to b2g in test manifests

RESOLVED FIXED in Firefox 62

Status

enhancement
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: jmaher, Assigned: apavel)

Tracking

unspecified
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

11 months ago
there are 3 manifests which have skip-if conditions related to b2g:
https://searchfox.org/mozilla-central/search?q=skip-if.*b2g&regexp=true&path=*.ini

please remove the b2g clauses and related comments.
Posted patch bug_1468199.patch (obsolete) — Splinter Review
Attachment #8984927 - Flags: review?(jmaher)
(Reporter)

Comment 2

11 months ago
Comment on attachment 8984927 [details] [diff] [review]
bug_1468199.patch

Review of attachment 8984927 [details] [diff] [review]:
-----------------------------------------------------------------

one small error, the rest looks good.

::: accessible/tests/mochitest/hittest/a11y.ini
@@ -5,4 @@
>  
>  [test_browser.html]
>  [test_canvas_hitregion.html]
> -skip-if = (os == "android" || appname == "b2g")

we need to keep the android clause here, only remove the clause that has b2g.
Attachment #8984927 - Flags: review?(jmaher) → review-
(Assignee)

Comment 3

11 months ago
Attachment #8984927 - Attachment is obsolete: true
Attachment #8985066 - Flags: review?(jmaher)
(Reporter)

Comment 4

11 months ago
Comment on attachment 8985066 [details] [diff] [review]
redid the patch with required modifications

Review of attachment 8985066 [details] [diff] [review]:
-----------------------------------------------------------------

really close

::: dom/xhr/tests/mochitest.ini
@@ +104,2 @@
>  [test_XHR_timeout.html]
> +skip-if = buildapp == (android_version == '18' && debug) 

buildapp == is not what we want here, just:
skip-if = (android_version == '18' && debug)

nit: please remove the trailing whitespace (at the end of the line)
Attachment #8985066 - Flags: review?(jmaher) → review-
(Assignee)

Comment 5

11 months ago
Attachment #8985066 - Attachment is obsolete: true
Attachment #8985080 - Flags: review?(jmaher)
(Reporter)

Updated

11 months ago
Attachment #8985080 - Flags: review?(jmaher) → review+
(Reporter)

Updated

11 months ago
Keywords: checkin-needed

Comment 6

11 months ago
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9e5997437dc
remove references to b2g in test manifests r=jmaher
Keywords: checkin-needed

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c9e5997437dc
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee: nobody → apavel
You need to log in before you can comment on or make changes to this bug.