Closed Bug 1468219 Opened 2 years ago Closed 2 years ago

Remove obj argument from JS_InitStandardClasses

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file, 2 obsolete files)

Similar to bug 1468137: JS_InitStandardClasses asserts cx and obj are same-compartment so that means it could just use cx->global() instead. This removes an obj->global() call so it helps bug 1466112.
Attachment #8984854 - Flags: review?(andrebargull)
Attachment #8984854 - Attachment is obsolete: true
Attachment #8984854 - Flags: review?(andrebargull)
Attachment #8984856 - Flags: review?(andrebargull)
Comment on attachment 8984856 [details] [diff] [review]
Remove obj argument from JS_InitStandardClasses

While we're changing this, maybe we should rename it to JS::InitRealmStandardClasses.
Attachment #8984856 - Flags: review?(andrebargull)
JS::InitRealmStandardClasses makes it a bit clearer this function operates on the current realm.
Attachment #8984856 - Attachment is obsolete: true
Attachment #8984858 - Flags: review?(andrebargull)
Attachment #8984858 - Attachment is patch: true
Comment on attachment 8984858 [details] [diff] [review]
Rename JS_InitStandardClasses to JS::InitRealmStandardClasses, remove obj argument

Review of attachment 8984858 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8984858 - Flags: review?(andrebargull) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/142288837f11
Rename JS_InitStandardClasses to JS::InitRealmStandardClasses, remove obj argument. r=anba
https://hg.mozilla.org/mozilla-central/rev/142288837f11
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.