1468315 - Firefox "Show all history" is missing "last seven days"

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[vvs009]

+++ This bug was initially created as a clone of Bug #890027 +++

User Agent: Mozilla/5.0 (X11; Fedora; Linux i686; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180530201721

Steps to reproduce:

Firefox "Show all history" is missing "last seven days"

Just trying to find my browsing history for two days ago on this day. Not available on my Firefox history.

Cloned this bug as it was closed unresolved and no activity in the last 26 days after actual reason was already posted.


Actual results:

No "last seven days" on "Show all history"

Firefox "Show all history" is missing "last seven days"


Expected results:

Needed "last seven days" to appear on "Show all history"


Actual reason:

I have that problem in released Firefox 60.0.1. As it turned out this happened when there were no more other visits than two days ago. In this case the query for that range will miss exactly that one day. The code for this query looks like this (in PlacesSQLQueryBuilder::SelectAsDay):

        sqlFragmentSearchBeginTime = sqlFragmentContainerBeginTime;
        sqlFragmentSearchEndTime = NS_LITERAL_CSTRING(
          "(strftime('%s','now','localtime','start of day','-2 days','utc')*1000000)");

While the last line apparently should include '-1 day' instead.

Comment 1

[Mark Banner (:standard8)]

Marco, can you comment on the suggested changes here? I'm wondering if changing to -1 day is going to break/change something else.

Comment 2

[Marco Bonardo [:mak]]

Yes, I think that's a valuable change, the scope of that code is checking if there are visits older than yesterday, that is '-1 day', 'start of day'.
I'll see how complex is to test it.

Comment 3

[Phabricator Automation]

Attachment: Bug 1468315 - 'Last seven days' container is missing from history if there are no visits older than 2 days ago. r=Standard8

The query checking which containers should be visible is wrong and skips the day before yesterday.

Comment 4

[Marco Bonardo [:mak]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=180999846524c01900662730d0159c5e1aababcb

Comment 5

[Phabricator Automation]

Comment on attachment 8986440 [details]
Bug 1468315 - 'Last seven days' container is missing from history if there are no visits older than 2 days ago. r=Standard8

Mark Banner (:standard8) has approved the revision.

https://phabricator.services.mozilla.com/D1725

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e4be76218d8
'Last seven days' container is missing from history if there are no visits older than 2 days ago. r=Standard8

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4e4be76218d8

Comment 8

[Timea Cernea [:tbabos][inactive]]

Managed to reproduce the issue on Firefox Nightly (2018-06-12) on Windows 10 x64, Mac OS X 10.13 and Ubuntu 16.04 x64.

The issue cannot be reproduced on the latest Nightly 63.0a1 (2018-06-26) (64-bit)/20180626220124 on Windows 10 x64, Mac OS X 10.13 and Ubuntu 16.04 x64 since the "Last seven days" container will be displayed.

Comment 9

[Timea Cernea [:tbabos][inactive]]

Also verified on latest Firefox Beta 62.0b3, the issue can no longer be reproduced on all the above mentioned OS.