Closed Bug 1468336 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11474 - ServiceWorker: Use [SecureContext] instead of manual check

Categories

(Core :: DOM: Service Workers, enhancement, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11474 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11474
Details from upstream follow.

Jinho Bang <jinho.bang@samsung.com> wrote:
>  ServiceWorker: Use [SecureContext] instead of manual check
>  
>  Until now, we had to use IsSecureContext() to check whether an execution
>  context is a secure context manually. But we can use [SecureContext]
>  instead of the manual check now. After this change, all related APIs
>  including ServiceWorkerContainer will not be exposed in non-secure
>  context.
>  
>  Bug: 542499
>  Change-Id: I0e207fee5c591d595c0e11c121cc8a0f555b5be3
>  
>  Reviewed-on: https://chromium-review.googlesource.com/818666
>  WPT-Export-Revision: 39db557de20ce592000232fc4e421e74c6f1cc58
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 7 tests and 305 subtests
OK     : 7
PASS   : 96
FAIL   : 209

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/service-workers/service-worker/http-to-https-redirect-and-register.https.html
    register on a non-secure page after redirect from an non-secure url: FAIL

New tests that have failures or other problems:
/BackgroundSync/interfaces.https.any.html
    ServiceWorkerRegistration interface: attribute sync: FAIL
    SyncManager interface object length: FAIL
    SyncManager interface object name: FAIL
    SyncManager interface: existence and properties of interface object: FAIL
    SyncManager interface: existence and properties of interface prototype object: FAIL
    SyncManager interface: existence and properties of interface prototype object's "constructor" property: FAIL
    SyncManager interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    SyncManager interface: operation getTags(): FAIL
    SyncManager interface: operation register(DOMString): FAIL
/BackgroundSync/interfaces.https.any.worker.html
    ServiceWorkerRegistration interface: attribute sync: FAIL
    SyncManager interface object length: FAIL
    SyncManager interface object name: FAIL
    SyncManager interface: existence and properties of interface object: FAIL
    SyncManager interface: existence and properties of interface prototype object: FAIL
    SyncManager interface: existence and properties of interface prototype object's "constructor" property: FAIL
    SyncManager interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    SyncManager interface: operation getTags(): FAIL
    SyncManager interface: operation register(DOMString): FAIL
/background-fetch/interfaces.https.html
    BackgroundFetchActiveFetch interface object length: FAIL
    BackgroundFetchActiveFetch interface object name: FAIL
    BackgroundFetchActiveFetch interface: attribute responseReady: FAIL
    BackgroundFetchActiveFetch interface: existence and properties of interface object: FAIL
    BackgroundFetchActiveFetch interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchActiveFetch interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchActiveFetch interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchActiveFetches interface object length: FAIL
    BackgroundFetchActiveFetches interface object name: FAIL
    BackgroundFetchActiveFetches interface: existence and properties of interface object: FAIL
    BackgroundFetchActiveFetches interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchActiveFetches interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchActiveFetches interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchActiveFetches interface: operation match(RequestInfo): FAIL
    BackgroundFetchActiveFetches interface: operation values(): FAIL
    BackgroundFetchFetch interface object length: FAIL
    BackgroundFetchFetch interface object name: FAIL
    BackgroundFetchFetch interface: attribute request: FAIL
    BackgroundFetchFetch interface: existence and properties of interface object: FAIL
    BackgroundFetchFetch interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchFetch interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchFetch interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchManager interface object length: FAIL
    BackgroundFetchManager interface object name: FAIL
    BackgroundFetchManager interface: existence and properties of interface object: FAIL
    BackgroundFetchManager interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchManager interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchManager interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchManager interface: operation fetch(DOMString, [object Object],[object Object], BackgroundFetchOptions): FAIL
    BackgroundFetchManager interface: operation get(DOMString): FAIL
    BackgroundFetchManager interface: operation getIds(): FAIL
    BackgroundFetchRegistration interface object length: FAIL
    BackgroundFetchRegistration interface object name: FAIL
    BackgroundFetchRegistration interface: attribute activeFetches: FAIL
    BackgroundFetchRegistration interface: attribute downloadTotal: FAIL
    BackgroundFetchRegistration interface: attribute downloaded: FAIL
    BackgroundFetchRegistration interface: attribute id: FAIL
    BackgroundFetchRegistration interface: attribute onprogress: FAIL
    BackgroundFetchRegistration interface: attribute uploadTotal: FAIL
    BackgroundFetchRegistration interface: attribute uploaded: FAIL
    BackgroundFetchRegistration interface: existence and properties of interface object: FAIL
    BackgroundFetchRegistration interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchRegistration interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchRegistration interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchRegistration interface: operation abort(): FAIL
    ServiceWorkerRegistration interface: attribute backgroundFetch: FAIL
/background-fetch/interfaces.https.worker.html
    BackgroundFetchActiveFetch interface object length: FAIL
    BackgroundFetchActiveFetch interface object name: FAIL
    BackgroundFetchActiveFetch interface: attribute responseReady: FAIL
    BackgroundFetchActiveFetch interface: existence and properties of interface object: FAIL
    BackgroundFetchActiveFetch interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchActiveFetch interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchActiveFetch interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchActiveFetches interface object length: FAIL
    BackgroundFetchActiveFetches interface object name: FAIL
    BackgroundFetchActiveFetches interface: existence and properties of interface object: FAIL
    BackgroundFetchActiveFetches interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchActiveFetches interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchActiveFetches interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchActiveFetches interface: operation match(RequestInfo): FAIL
    BackgroundFetchActiveFetches interface: operation values(): FAIL
    BackgroundFetchFetch interface object length: FAIL
    BackgroundFetchFetch interface object name: FAIL
    BackgroundFetchFetch interface: attribute request: FAIL
    BackgroundFetchFetch interface: existence and properties of interface object: FAIL
    BackgroundFetchFetch interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchFetch interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchFetch interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchManager interface object length: FAIL
    BackgroundFetchManager interface object name: FAIL
    BackgroundFetchManager interface: existence and properties of interface object: FAIL
    BackgroundFetchManager interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchManager interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchManager interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchManager interface: operation fetch(DOMString, [object Object],[object Object], BackgroundFetchOptions): FAIL
    BackgroundFetchManager interface: operation get(DOMString): FAIL
    BackgroundFetchManager interface: operation getIds(): FAIL
    BackgroundFetchRegistration interface object length: FAIL
    BackgroundFetchRegistration interface object name: FAIL
    BackgroundFetchRegistration interface: attribute activeFetches: FAIL
    BackgroundFetchRegistration interface: attribute downloadTotal: FAIL
    BackgroundFetchRegistration interface: attribute downloaded: FAIL
    BackgroundFetchRegistration interface: attribute id: FAIL
    BackgroundFetchRegistration interface: attribute onprogress: FAIL
    BackgroundFetchRegistration interface: attribute uploadTotal: FAIL
    BackgroundFetchRegistration interface: attribute uploaded: FAIL
    BackgroundFetchRegistration interface: existence and properties of interface object: FAIL
    BackgroundFetchRegistration interface: existence and properties of interface prototype object: FAIL
    BackgroundFetchRegistration interface: existence and properties of interface prototype object's "constructor" property: FAIL
    BackgroundFetchRegistration interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    BackgroundFetchRegistration interface: operation abort(): FAIL
    ServiceWorkerGlobalScope interface: attribute onbackgroundfetchabort: FAIL
    ServiceWorkerGlobalScope interface: attribute onbackgroundfetchclick: FAIL
    ServiceWorkerGlobalScope interface: attribute onbackgroundfetched: FAIL
    ServiceWorkerGlobalScope interface: attribute onbackgroundfetchfail: FAIL
    ServiceWorkerRegistration interface: existence and properties of interface object: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3558f79c788
[wpt PR 11474] - ServiceWorker: Use [SecureContext] instead of manual check, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbd76b012da
[wpt PR 11474] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/e3558f79c788
https://hg.mozilla.org/mozilla-central/rev/9cbd76b012da
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.