1468362 - Remove ADDON_SIGNING build config setting

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Kris Maglione [:kmag]]

It's not useful anymore

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1468362: Remove ADDON_SINGING buildconfig setting.

Review commit: https://reviewboard.mozilla.org/r/250760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250760/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8985034 [details]
Bug 1468362: Remove ADDON_SINGING buildconfig setting.

https://reviewboard.mozilla.org/r/250760/#review257658

::: commit-message-75a32:1
(Diff revision 1)
> +Bug 1468362: Remove ADDON_SINGING buildconfig setting. r?aswan

*SIGNING

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e02d4ae900f113df8d694a4683233b2429aa713
Bug 1468362: Remove ADDON_SINGING buildconfig setting. r=aswan

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae53daca209dbd89f12071e055de201e8328e078
Bug 1468362: Follow-up: Remove unused import. r=eslint-fix CLOSED TREE

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8e02d4ae900f
https://hg.mozilla.org/mozilla-central/rev/ae53daca209d

Comment 6

[Jorg K (CEST = GMT+2)]

Hmm, we've just switched on MOZ_ADDON_SIGNING=1 in
https://hg.mozilla.org/comm-central/rev/6b07fdab82bf

Now it's not useful any more? So we just remove those lines?

Comment 7

[Andrew Swan [:aswan]]

(In reply to Jorg K (GMT+2) from comment #6)
> Hmm, we've just switched on MOZ_ADDON_SIGNING=1 in
> https://hg.mozilla.org/comm-central/rev/6b07fdab82bf
> 
> Now it's not useful any more? So we just remove those lines?

Yes

Comment 8

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.