Closed Bug 1468362 Opened Last year Closed Last year

Remove ADDON_SIGNING build config setting

Categories

(Toolkit :: Add-ons Manager, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: kmag, Assigned: kmag)

Details

Attachments

(1 file)

It's not useful anymore
Comment on attachment 8985034 [details]
Bug 1468362: Remove ADDON_SINGING buildconfig setting.

https://reviewboard.mozilla.org/r/250760/#review257658

::: commit-message-75a32:1
(Diff revision 1)
> +Bug 1468362: Remove ADDON_SINGING buildconfig setting. r?aswan

*SIGNING
Attachment #8985034 - Flags: review?(aswan) → review+
https://hg.mozilla.org/mozilla-central/rev/8e02d4ae900f
https://hg.mozilla.org/mozilla-central/rev/ae53daca209d
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Hmm, we've just switched on MOZ_ADDON_SIGNING=1 in
https://hg.mozilla.org/comm-central/rev/6b07fdab82bf

Now it's not useful any more? So we just remove those lines?
Flags: needinfo?(aswan)
(In reply to Jorg K (GMT+2) from comment #6)
> Hmm, we've just switched on MOZ_ADDON_SIGNING=1 in
> https://hg.mozilla.org/comm-central/rev/6b07fdab82bf
> 
> Now it's not useful any more? So we just remove those lines?

Yes
Flags: needinfo?(aswan)
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in before you can comment on or make changes to this bug.