Closed Bug 1468379 Opened 3 years ago Closed 3 years ago

Remove unneeded code added in bug 1458682 in test_webextension_theme.js

Categories

(WebExtensions :: Themes, enhancement)

enhancement
Not set
normal

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1458682 +++

In bug 1458682 some code was added to help Thunderbird:
https://hg.mozilla.org/mozilla-central/rev/bb912ad63b04#l1.12

TB now switched to add-on signing, so this code can be removed again.
Attached patch 1468379.patchSplinter Review
I need to check that this can really be removed. With this patch, the test fails locally in TB.
Comment on attachment 8985051 [details] [diff] [review]
1468379.patch

Test passes locally in TB after rebuild with MOZ_ADDON_SIGNING=1.
Attachment #8985051 - Flags: review?(aswan)
Comment on attachment 8985051 [details] [diff] [review]
1468379.patch

Review of attachment 8985051 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8985051 - Flags: review?(aswan) → review+
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c616631284f4
Remove unneeded code added for Thunderbird in bug 1458682 in test_webextension_theme.js. r=aswan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c616631284f4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Product: Toolkit → WebExtensions
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.