Closed
Bug 1468379
Opened 7 years ago
Closed 7 years ago
Remove unneeded code added in bug 1458682 in test_webextension_theme.js
Categories
(WebExtensions :: Themes, enhancement)
WebExtensions
Themes
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
Details
Attachments
(1 file)
|
1.12 KB,
patch
|
aswan
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1458682 +++
In bug 1458682 some code was added to help Thunderbird:
https://hg.mozilla.org/mozilla-central/rev/bb912ad63b04#l1.12
TB now switched to add-on signing, so this code can be removed again.
|
Assignee | |
Comment 1•7 years ago
|
||
I need to check that this can really be removed. With this patch, the test fails locally in TB.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8985051 [details] [diff] [review]
1468379.patch
Test passes locally in TB after rebuild with MOZ_ADDON_SIGNING=1.
Attachment #8985051 -
Flags: review?(aswan)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8985051 [details] [diff] [review]
1468379.patch
Review of attachment 8985051 [details] [diff] [review]:
-----------------------------------------------------------------
thanks!
Attachment #8985051 -
Flags: review?(aswan) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c616631284f4
Remove unneeded code added for Thunderbird in bug 1458682 in test_webextension_theme.js. r=aswan
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
|
||
Updated•7 years ago
|
Product: Toolkit → WebExtensions
|
|
||
Updated•7 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•