Closed
Bug 1468406
Opened 6 years ago
Closed 6 years ago
Remove JSObject::realm()
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(4 files)
1.02 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
4.33 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
9.38 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
27.08 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Similar to bug 1468252, but for JSObject::realm() instead of JSObject::global().
Assignee | ||
Updated•6 years ago
|
Summary: Remove JSObject::realm → Remove JSObject::realm()
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8985375 -
Flags: review?(luke)
Assignee | ||
Comment 2•6 years ago
|
||
JSObject::globalForTracing and JSObject::isOwnGlobal can be inlined in JS_GlobalObjectTraceHook. This removes a number of JSObject::realm() calls.
Attachment #8985376 -
Flags: review?(jcoppeard)
Updated•6 years ago
|
Attachment #8985376 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8985475 -
Flags: review?(evilpies)
Updated•6 years ago
|
Attachment #8985375 -
Flags: review?(luke) → review+
Updated•6 years ago
|
Attachment #8985475 -
Flags: review?(evilpies) → review+
Assignee | ||
Comment 4•6 years ago
|
||
This replaces the remaining realm() calls with either nonCCWRealm(), maybeCCWRealm(), or deprecatedRealm().
Attachment #8985626 -
Flags: review?(luke)
Updated•6 years ago
|
Attachment #8985626 -
Flags: review?(luke) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8695dbfdc556 part 1 - Add NativeObject::realm(), forwarding to JSObject::realm() for now. r=luke https://hg.mozilla.org/integration/mozilla-inbound/rev/7c8ab030787b part 2 - Simplify JS_GlobalObjectTraceHook. r=jonco https://hg.mozilla.org/integration/mozilla-inbound/rev/db80d5a4d8e9 part 3 - Add some obj->as<Foo>() casts to eliminate some JSObject::realm() calls. r=evilpie
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8695dbfdc556 https://hg.mozilla.org/mozilla-central/rev/7c8ab030787b https://hg.mozilla.org/mozilla-central/rev/db80d5a4d8e9
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/49cbcdeaa8bb part 4 - Remove remaining JSObject::realm() calls. r=luke
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Assignee | ||
Comment 8•6 years ago
|
||
Oops, some devtools orange because the nonCCWRealm call in DebuggerObject::unwrap is incorrect (not sure what I was thinking and I missed this on Try) - asked the sheriffs to back out and will reland later with s/nonCCWRealm/deprecatedRealm/ for now.
Comment 9•6 years ago
|
||
Backed out for failing devtools at devtools/client/debugger/new/test/mochitest/browser_dbg-content-script-sources.js Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=49cbcdeaa8bb951088c7e313fcd18fbb4a787cfc Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=183951151&repo=mozilla-inbound&lineNumber=3567 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/54f8630a56698e6dd2c51244fc68f048cafa2314
Flags: needinfo?(jdemooij)
Comment 10•6 years ago
|
||
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/77b8ddea1fbd part 4 - Remove remaining JSObject::realm() calls. r=luke
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(jdemooij)
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/77b8ddea1fbd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•