1468443 - Consider the "active tab" as part of the multi-selection by default

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Abdoulaye O. LY]

A Note though:

When user Ctrl/Cmd+Click on the active tab, switch to the last multi-selected tab and clear the multi-selection.

Comment 1

[Abdoulaye O. LY]

Attachment: Bug 1468443 - Consider the 'active tab'(gBrowser.selectedTab) as part of the multi-selection by default.

Review commit: https://reviewboard.mozilla.org/r/252112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252112/

Comment 2

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8986874 [details]
Bug 1468443 - Consider the 'active tab'(gBrowser.selectedTab) as part of the multi-selection by default.

https://reviewboard.mozilla.org/r/252112/#review258626

::: browser/base/content/test/tabs/browser.ini:57
(Diff revision 1)
>  [browser_multiselect_tabs_close_using_shortcuts.js]
>  [browser_multiselect_tabs_mute_unmute.js]
>  support-files =
>    ../general/audio.ogg
>    ../general/file_mediaPlayback.html
> +[browser_multiselect_tabs_active_tab_selected_by_default.js]

I just noticed that the browsre_multiselect* tests are not in alphabetical order within this file. Can you file a follow-up bug to put these in alphabetical order?

Or you can do that as a separate commit in this bug if you would like.

Comment 3

[Abdoulaye O. LY]

Attachment: Bug 1468443 - Reorder browser/base/content/tests/tabs/browser.ini in alphabetic order.

Review commit: https://reviewboard.mozilla.org/r/252180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252180/

Comment 4

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8986943 [details]
Bug 1468443 - Reorder browser/base/content/tests/tabs/browser.ini in alphabetic order.

https://reviewboard.mozilla.org/r/252180/#review258858

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0f2ca34fbfb
Consider the 'active tab'(gBrowser.selectedTab) as part of the multi-selection by default. r=jaws
https://hg.mozilla.org/integration/autoland/rev/90e54fb8d5a8
Reorder browser/base/content/tests/tabs/browser.ini in alphabetic order. r=jaws

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d0f2ca34fbfb
https://hg.mozilla.org/mozilla-central/rev/90e54fb8d5a8

Comment 7

[Vlad Lucaci, QA (:vlucaci)]

Verified fixed in latest nightly 65.0a1(2018-11-07) and latest Beta 64.0b7.