Consider the "active tab" as part of the multi-selection by default

VERIFIED FIXED in Firefox 62

Status

()

enhancement
P3
normal
VERIFIED FIXED
Last year
9 months ago

People

(Reporter: ablayelyfondou, Assigned: ablayelyfondou, Mentored)

Tracking

(Blocks 1 bug)

Trunk
Firefox 62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed, firefox64 verified, firefox65 verified)

Details

Attachments

(2 attachments)

A Note though:

When user Ctrl/Cmd+Click on the active tab, switch to the last multi-selected tab and clear the multi-selection.
Blocks: 1458007
Depends on: 1458022, 1458039
Comment on attachment 8986874 [details]
Bug 1468443 - Consider the 'active tab'(gBrowser.selectedTab) as part of the multi-selection by default.

https://reviewboard.mozilla.org/r/252112/#review258626

::: browser/base/content/test/tabs/browser.ini:57
(Diff revision 1)
>  [browser_multiselect_tabs_close_using_shortcuts.js]
>  [browser_multiselect_tabs_mute_unmute.js]
>  support-files =
>    ../general/audio.ogg
>    ../general/file_mediaPlayback.html
> +[browser_multiselect_tabs_active_tab_selected_by_default.js]

I just noticed that the browsre_multiselect* tests are not in alphabetical order within this file. Can you file a follow-up bug to put these in alphabetical order?

Or you can do that as a separate commit in this bug if you would like.
Attachment #8986874 - Flags: review?(jaws) → review+
Comment on attachment 8986943 [details]
Bug 1468443 - Reorder browser/base/content/tests/tabs/browser.ini in alphabetic order.

https://reviewboard.mozilla.org/r/252180/#review258858
Attachment #8986943 - Flags: review?(jaws) → review+
Assignee: nobody → ablayelyfondou
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0f2ca34fbfb
Consider the 'active tab'(gBrowser.selectedTab) as part of the multi-selection by default. r=jaws
https://hg.mozilla.org/integration/autoland/rev/90e54fb8d5a8
Reorder browser/base/content/tests/tabs/browser.ini in alphabetic order. r=jaws
https://hg.mozilla.org/mozilla-central/rev/d0f2ca34fbfb
https://hg.mozilla.org/mozilla-central/rev/90e54fb8d5a8
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Depends on: 1470677
No longer depends on: 1470677
Depends on: 1472910
No longer depends on: 1472910
Verified fixed in latest nightly 65.0a1(2018-11-07) and latest Beta 64.0b7.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.