1468446 - `arc diff` fails with "Unknown Mercurial log field 'instability'!"

Status: VERIFIED FIXED

(Conduit :: Phabricator, defect)

Description

[Osmose [:osmose, :mkelly]]

Here's the output with --trace:

```
└─❱❱❱ arc diff --trace                                                                                                                                                                                                       +10176 22:04 ❰─┘
 ARGV  '/Users/osmose/Projects/arcanist/bin/../scripts/arcanist.php' 'diff' '--trace'
 LOAD  Loaded "phutil" from "/Users/osmose/Projects/libphutil/src".
 LOAD  Loaded "arcanist" from "/Users/osmose/Projects/arcanist/src".
Config: Reading user configuration file "/Users/osmose/.arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: Reading .arcconfig from "/Users/osmose/Projects/mozilla-unified/.arcconfig".
Working Copy: Path "/Users/osmose/Projects/mozilla-unified" is part of `hg` working copy "/Users/osmose/Projects/mozilla-unified".
Working Copy: Project root is at "/Users/osmose/Projects/mozilla-unified".
Config: Did not find local configuration at "/Users/osmose/Projects/mozilla-unified/.hg/arc/config".
>>> [0] <http> https://phabricator.services.mozilla.com/api/user.whoami
<<< [0] <http> 223,933 us
>>> [1] <exec> $ HGPLAIN=1 hg status
<<< [1] <exec> 509,464 us
>>> [2] <event> diff.didCollectChanges <listeners = 0>
<<< [2] <event> 44 us
>>> [3] <exec> $ HGPLAIN=1 hg help phase
<<< [3] <exec> 320,697 us
>>> [4] <exec> $ HGPLAIN=1 hg branch
<<< [4] <exec> 346,659 us
>>> [5] <exec> $ HGPLAIN=1 hg log --branch 'default' -r 'draft()' --style default
<<< [5] <exec> 515,972 us

[2018-06-13 05:04:06] EXCEPTION: (Exception) Unknown Mercurial log field 'instability'! at [<arcanist>/src/repository/parser/ArcanistMercurialParser.php:182]
arcanist(head=master, ref.master=df7313bdf2a3), phutil(head=master, ref.master=4206849bb05b)
  #0 ArcanistMercurialParser::parseMercurialLog(string) called at [<arcanist>/src/repository/api/ArcanistMercurialAPI.php:169]
  #1 ArcanistMercurialAPI::buildBaseCommit(NULL) called at [<arcanist>/src/repository/api/ArcanistRepositoryAPI.php:599]
  #2 ArcanistRepositoryAPI::getBaseCommit() called at [<arcanist>/src/repository/api/ArcanistMercurialAPI.php:619]
  #3 ArcanistMercurialAPI::getCommitMessageLog() called at [<arcanist>/src/repository/api/ArcanistMercurialAPI.php:641]
  #4 ArcanistMercurialAPI::loadWorkingCopyDifferentialRevisions(ConduitClient, array) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1477]
  #5 ArcanistDiffWorkflow::buildCommitMessage() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:469]
  #6 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]
```

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Encountered same message.

The following arcanist patch allowed me to upload a revision: 

diff --git a/src/repository/parser/ArcanistMercurialParser.php b/src/repository/parser/ArcanistMercurialParser.php
index 4eb10e2f..d58964c5 100644
--- a/src/repository/parser/ArcanistMercurialParser.php
+++ b/src/repository/parser/ArcanistMercurialParser.php
@@ -175,6 +175,7 @@ final class ArcanistMercurialParser extends Phobject {
             $commit['bookmark'] = $value;
             break;
           case 'obsolete':
+          case 'instability':
             // This is an extra field added by the "evolve" extension even
             // if HGPLAIN=1 is set. See PHI502.
             break;

Comment 2

[Steven MacLeod [:smacleod]]

Filed upstream as https://admin.phacility.com/PHI718

Very similar to previously filed Bug 1448137 and will most likely be fixed quickly.

Comment 3

[Steven MacLeod [:smacleod]]

Upstream fix: https://secure.phabricator.com/D19498

Comment 4

[Steven MacLeod [:smacleod]]

This has now landed in upstream master and should move to the stable branch on Friday. Running `arc upgrade` should pick it up at that point.

:mkelly, can you verify this is working for you after it moves to stable?

Comment 5

[Osmose [:osmose, :mkelly]]

After running `arc upgrade` I was able to successfully run `arc diff`. Thanks!