Remove nsXBLSpecialDocInfo::mUserHTMLBindings

RESOLVED FIXED in Firefox 62

Status

()

RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

(Blocks: 1 bug)

Trunk
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

With bug 1367286, mUserHTMLBindings is always nullptr.
Also nsXBLWindowKeyHandler::mUserHandler
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Attachment #8985230 - Flags: review?(enndeakin)
Attachment #8985230 - Flags: review?(enndeakin) → review?(bugs)

Comment 4

8 months ago
mozreview-review
Comment on attachment 8985230 [details]
Bug 1468557 - Remove nsXBLWindowKeyHandler::mUserHandler and nsXBLSpecialDocInfo::mUserHTMLBindings

https://reviewboard.mozilla.org/r/250854/#review257710

::: dom/xbl/nsXBLWindowKeyHandler.cpp:404
(Diff revision 2)
>  {
>    // Load the XBL handlers
>    EnsureSpecialDocInfo();
>  
>    nsXBLPrototypeHandler* handlers = nullptr;
>    nsXBLPrototypeHandler* userHandlers = nullptr;

Remove userHandlers variable
Attachment #8985230 - Flags: review?(bugs) → review+
Blocks: 1397874
Comment hidden (mozreview-request)

Comment 6

8 months ago
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8e1ec724d06f
Remove nsXBLWindowKeyHandler::mUserHandler and nsXBLSpecialDocInfo::mUserHTMLBindings r=smaug

Comment 7

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8e1ec724d06f
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox62: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.