Closed Bug 1468557 Opened 2 years ago Closed 2 years ago

Remove nsXBLSpecialDocInfo::mUserHTMLBindings

Categories

(Core :: XBL, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

With bug 1367286, mUserHTMLBindings is always nullptr.
Also nsXBLWindowKeyHandler::mUserHandler
Attachment #8985230 - Flags: review?(enndeakin)
Attachment #8985230 - Flags: review?(enndeakin) → review?(bugs)
Comment on attachment 8985230 [details]
Bug 1468557 - Remove nsXBLWindowKeyHandler::mUserHandler and nsXBLSpecialDocInfo::mUserHTMLBindings

https://reviewboard.mozilla.org/r/250854/#review257710

::: dom/xbl/nsXBLWindowKeyHandler.cpp:404
(Diff revision 2)
>  {
>    // Load the XBL handlers
>    EnsureSpecialDocInfo();
>  
>    nsXBLPrototypeHandler* handlers = nullptr;
>    nsXBLPrototypeHandler* userHandlers = nullptr;

Remove userHandlers variable
Attachment #8985230 - Flags: review?(bugs) → review+
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8e1ec724d06f
Remove nsXBLWindowKeyHandler::mUserHandler and nsXBLSpecialDocInfo::mUserHTMLBindings r=smaug
https://hg.mozilla.org/mozilla-central/rev/8e1ec724d06f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.