1468583 - Log explicitly join of http transaction with http2 stream

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Honza Bambas (:mayhemer)]

I think we are OK with logging the most common case only - a content (or navigational) request coming from the side of the browser (=not a push request)

Constructor of h2 stream is probably the place.

P2 since this may significantly slow diagnosing logs.

Comment 1

[Phabricator Automation]

Attachment: Bug 1468583 - Explicitly tie h2stream to transaction in logs for logan.

Comment 2

[Phabricator Automation]

Comment on attachment 8985411 [details]
Bug 1468583 - Explicitly tie h2stream to transaction in logs for logan.

Valentin Gosu [:valentin] has approved the revision.

https://phabricator.services.mozilla.com/D1656

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2663d407a55a
Explicitly tie h2stream to transaction in logs for logan. r=valentin

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2663d407a55a

Comment 5

[Honza Bambas (:mayhemer)]

Thanks, works flawlessly now!

Comment 6

[Honza Bambas (:mayhemer)]

OTOH, what is the case when the transaction object is nullptr?

I can see:
2018-08-15 12:48:40.052000 UTC - [Parent 10640: Socket Thread]: I/nsHttp Http2Stream::Http2Stream 000002CB891BD240 trans=0000000000000000 atrans=000002CB90A59680

Comment 7

[u408661]

(In reply to Honza Bambas (:mayhemer) from comment #6)
> OTOH, what is the case when the transaction object is nullptr?
> 
> I can see:
> 2018-08-15 12:48:40.052000 UTC - [Parent 10640: Socket Thread]: I/nsHttp
> Http2Stream::Http2Stream 000002CB891BD240 trans=0000000000000000
> atrans=000002CB90A59680

That's... a good question! I suspect it's something a tad wonky with a speculative connection (which has a NullHttpTransaction, so when queried to nsHttpTransaction it'll return nullptr). Almost certainly harmless (and so low-priority), but worth making sure. Mind filing a follow-up and assigning to me (P3) so I can remember to take a look?