Closed
Bug 1468583
Opened 6 years ago
Closed 6 years ago
Log explicitly join of http transaction with http2 stream
Categories
(Core :: Networking: HTTP, enhancement, P2)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mayhemer, Assigned: u408661)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
I think we are OK with logging the most common case only - a content (or navigational) request coming from the side of the browser (=not a push request) Constructor of h2 stream is probably the place. P2 since this may significantly slow diagnosing logs.
Reporter | ||
Updated•6 years ago
|
Whiteboard: [necko-triaged]
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8985411 [details] Bug 1468583 - Explicitly tie h2stream to transaction in logs for logan. Valentin Gosu [:valentin] has approved the revision. https://phabricator.services.mozilla.com/D1656
Attachment #8985411 -
Flags: review+
Pushed by hurley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2663d407a55a Explicitly tie h2stream to transaction in logs for logan. r=valentin
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2663d407a55a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Reporter | ||
Comment 5•6 years ago
|
||
Thanks, works flawlessly now!
Reporter | ||
Comment 6•6 years ago
|
||
OTOH, what is the case when the transaction object is nullptr? I can see: 2018-08-15 12:48:40.052000 UTC - [Parent 10640: Socket Thread]: I/nsHttp Http2Stream::Http2Stream 000002CB891BD240 trans=0000000000000000 atrans=000002CB90A59680
(In reply to Honza Bambas (:mayhemer) from comment #6) > OTOH, what is the case when the transaction object is nullptr? > > I can see: > 2018-08-15 12:48:40.052000 UTC - [Parent 10640: Socket Thread]: I/nsHttp > Http2Stream::Http2Stream 000002CB891BD240 trans=0000000000000000 > atrans=000002CB90A59680 That's... a good question! I suspect it's something a tad wonky with a speculative connection (which has a NullHttpTransaction, so when queried to nsHttpTransaction it'll return nullptr). Almost certainly harmless (and so low-priority), but worth making sure. Mind filing a follow-up and assigning to me (P3) so I can remember to take a look?
You need to log in
before you can comment on or make changes to this bug.
Description
•