1468623 - Resizing job details / pinboard panel no longer works

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Description

[George Hickman]

When moving your mouse over the top of the tab bar/pinboard it switches to the resize icon but clicking and dragging has no effect.

Comment 1

[Cameron Dawson [:camd]]

I must have broken this in the React transition.  But this is slightly lower priority than other things.  I'll get to it as soon as I can, though.

Comment 3

[Botond Ballo [:botond]]

(In reply to Cameron Dawson [:camd] from comment #1)
> I must have broken this in the React transition.  But this is slightly lower
> priority than other things.

The available vertical space in the pinboard panel, especially after pressing the spacebar, is very low. I find I almost always have to increase the vertical height to be able to scroll through the list of failures in a job with anything resembling comfort.

Perhaps, as a temporary measure, we could increase the default height of the panel (perhaps even just after you've pressed the spacebar)?

Comment 4

[Jonathan French (:jfrench)]

Fwiw during the React conversion the angular mcResizer was removed but it doesn't appear a React equivalent was added.
https://github.com/mozilla/treeherder/pull/3621/files#diff-5199a75957e6fd7bba294d1418e0e1bc

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3718

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8987987 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3718

Removing the review for now.  I'm hitting issues with window resizing and wrapping that are making this challenging.  I'll re-add when I've got them resolved.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/efe5c2166d181e688c77d13cef0c7854989b49c3
Bug 1468623 - Fix resizing job details / pinboard panel (#3718)

Comment 8

[Cameron Dawson [:camd]]

There was an updated to react-split-pane that appears to have broken this again.

Comment 9

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #8)
> There was an updated to react-split-pane that appears to have broken this
> again.

The update was a patch version, so any breakage would be a bug - so good to report upstream. Checking their issue tracker it seems like it might be the same as:
https://github.com/tomkp/react-split-pane/issues/285

Could you comment there?

Comment 10

[Cameron Dawson [:camd]]

Yeah, I agree, it's that issue.  I commented in that issue as to the error I was getting.  But switching to ``onChange`` on their component fixes it.  I had originally used the ``onDragFinished`` because it felt a bit faster (since it didn't update in real-time).  But now that I switched, I don't think it's THAT much slower.  :)

Comment 11

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3765

Comment 12

[Ed Morley [:emorley]]

Comment on attachment 8990171 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3765

:-)

Comment 13

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/750964dc096e6e8765a3b4a2479196d415191a7d
Bug 1468623 - Re-fix resizing job details after lib upgrade (#3765)