1468686 - Move 216 search XML files from l10n-central to mail/components/search/searchplugins

Status: RESOLVED DUPLICATE of bug 1427133

(Thunderbird :: Search, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1468240 +++

As per bug 1468240 comment #10:

Move 216 search XML files from the mail directories here
https://dxr.mozilla.org/l10n-central/search?q=file%3A*.xml&redirect=false
into mail/components/search/searchplugins and remove from the l10n tree.

NI'ing a few people who might know how to proceed here.

Comment 1

[Onno Ekker [:nONoNonO UTC+1]]

I can most probably help with scripting this and making it work for Mercurial, but I guess flod first needs to do some magic on Pontoon in order to keep current translation status. Or are the files pulled out of localization altogether?
Anyway, I also probably need some more info, like if a similar tree of folders should be build under mail/components/search/searchplugins, and if not, what should be done with duplicate filenames, etc...

Comment 2

[Francesco Lodolo [:flod]]

My advice would be to not touch l10n repos at all for now, given cross channel (same repo is used for multiple versions of Thunderbird).

I can help removing those files when necessary, in the meantime they'll just stay in the repo and be unused.

Searchplugins have no relation with Pontoon at all.

Comment 3

[Francesco Lodolo [:flod]]

Side thought: I would strongly suggest to clean up searchplugins when moving them around, or soon after.

You'll will have duplicates, broken searchplugins, and search defined for locales that don't ship anywhere. It would also be nice to clean up all open bugs related to search and TB…

Comment 4

[Jorg K (CEST = GMT+2)]

Volunteers? ;-)

Comment 5

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: coSimple script to copy searchplugin files to tree

The attached script copies all searchplugin files from L10NBASEDIR to DESTDIR, where DESTDIR is the tree folder. Instead of moving the files, I copy them, because they need to stay in the l10n-directory for other builds.
If a file already exists, you are prompted to overwrite it (flag -i)
The original file attributes are preserved (flag -p)

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

Maybe wsmwk can help create a query for all open bugs related to search and TB and we can see if they need truiaging and wqhat needs to be done to fix them

Comment 7

[Wayne Mery (:wsmwk)]

https://mzl.la/2HNUbzL is a quick and dirty query.

I'm unsure what a more sophisticated query might look like

Comment 8

[Francesco Lodolo [:flod]]

I was more thinking of this
https://mzl.la/2t9dhL7

Comment 9

[Ian Neal]

I think this has been superseded by bug 1427133