1468705 - Cannot tell that a tab is multiselected while hovering over it

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Kestrel]

STR:
1. Move mouse cursor over tab.
2. Hold Ctrl and click 5-10 times without counting.
3. Is the tab selected?

The tab multiselected style is the same as the hover style, so when selecting a tab there is no visual feedback that it is selected until the mouse cursor is moved off the tab.

Comment 1

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Amy, what should we do here?

Comment 2

[Abdoulaye O. LY]

Yes you're right Kresnel. Maybe setting the tab-line colored with 0.5 (or lower) opacity in a context of hover + multi-selection would fix this.

Comment 3

[Abdoulaye O. LY]

Kestrel*.

Comment 4

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Yes, that should work.

Comment 5

[Amy Lee [:amylee] UX]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> Amy, what should we do here?

Hi, 

The hover state should be the same as it is currently. A selected state (that is not the active tab should be the same as a hover state except with a blue highlight strip at the top. Please see Invision spec for reference. 

Thanks!

Comment 6

[Abdoulaye O. LY]

Attachment: Bug 1468705 - Set tab-line opacity to 0.5 on multi-select and hover context.

Review commit: https://reviewboard.mozilla.org/r/252970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252970/

Comment 7

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8987724 [details]
Bug 1468705 - Set tab-line opacity to 0.5 on multi-select and hover context.

https://reviewboard.mozilla.org/r/252970/#review259738

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5dabd4f0b32
Set tab-line opacity to 0.5 on multi-select and hover context. r=jaws

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a5dabd4f0b32

Comment 10

[Pascal Chevrel:pascalc]

Marking as wontfix for firefox62 as this feature is currently targeting firefox63.

Comment 11

[Md. Majedul islam]

I have reproduced this bug with Nightly 62.0a1(2018-06-14) on Windows 10, 64 bit!

The fix is now verified on Latest Nightly.

Build ID 	20181007100131
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

[bugday-20181003]

Comment 12

[Vlad Lucaci, QA (:vlucaci)]

Verified fixed in latest nightly 65.0a1(2018-11-07) and latest Beta 64.0b7 on Windows 10x64, macOS 10.13 and Ubuntu 16.04x64.