Closed
Bug 1468725
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11504 - CSSStyleDeclaration: Stop calling ScriptState::ContextIsValid() in the setter
Categories
(Core :: DOM: CSS Object Model, enhancement, P4)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11504 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11504 Details from upstream follow. Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> wrote: > CSSStyleDeclaration: Stop calling ScriptState::ContextIsValid() in the setter > > When the custom bindings were removed in commit 5b84e88a0 ("Remove custom > bindings for CSSStyleDeclaration"), the new anonymous setter code added a > check for ScriptState::ContextIsValid() to ensure it had received a valid > |script_state|. > > It turns out this check is too strict, as in addition to verifying a > ScriptState has an associated v8::Context it also asserts the ScriptState > has a valid |per_context_data_|. > > This is valid in most cases, but when a node is moved across different > documents and its previous document gets removed its |per_context_data_| is > disposed of and ScriptState::ContextIsValid() fails. > > Since the anonymous setter is only invoked by the bindings layer, we can > assume it is passed a ScriptState that is in a minimally usable state, so it > is possible to relax the ContextIsValid() check and only make sure we can > get a valid ExecutionContext from the ScriptState. > > Bug: 852190 > Change-Id: I307de0e003e5258bf1f670b26f1dc86e4dae9286 > Reviewed-on: https://chromium-review.googlesource.com/1100836 > WPT-Export-Revision: 4eac66618a9160f7fe8bb9330cdda301f2096829
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=97c25342c2f4ee8f25de991d5d714dfd33da754b
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=239df208cb81e12f668e7612ade1cfb6e1e6a7bf
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b46fbcac9d42b4f9eed3e92efe1b11e56986121
Assignee | ||
Comment 4•6 years ago
|
||
Ran 1 tests and 1 subtests OK : 1 PASS : 1
Assignee | ||
Comment 5•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=36a2fe188a201679adabf6628caf0f9dac38e13f
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/443ab707c354 [wpt PR 11504] - CSSStyleDeclaration: Stop calling ScriptState::ContextIsValid() in the setter, a=testonly
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/443ab707c354
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•