1468728 - White rectangles on page

Status: VERIFIED FIXED

(Core :: Web Painting, defect, P2)

Description

[victor.kovtun]

Attachment: 20180614_151207.jpg

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180607190419

Steps to reproduce:

1. Go to the site https://slidewiki.org/presentation/584-14/semantic-data-web-lecture/2038-5/15160-2/#/slide-15160-2.
2. Navigate through the slides using left and right buttons.


Actual results:

At some point various white rectangles cover the page. The rectangles disappear when the browser loses focus or when the user clicks somewhere on the screen (but it does not always help).

The issue is also reproduced in the safe mode and with hardware acceleration switched off.

The image was taken by a camera, because the artifacts disappear when performing screenshot.


Expected results:

There should be no blank rectangles.

Comment 1

[Mayank Bansal]

This is pretty easy to reproduce with WR Disabled. This is not a WR bug.

I checked, and this reproduces with OMTP and/or retain-DL disabled.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Also the UA string from comment 0 says Firefox 60, in which WR cannot be enabled.

Comment 3

[Darkspirit]

mozregression --good 2017-07-15 --bad 2017-09-15 --pref startup.homepage_welcome_url:'https://slidewiki.org/presentation/584-14/semantic-data-web-lecture/2038-5/15160-2/#/slide-15160-2'
> 6:32.55 INFO: Last good revision: 1704a6f949aff1d8101061645ede31ca96b572f8
> 6:32.55 INFO: First bad revision: 78676939447ffd59eb7a265fbd78a384d30136ec
> 6:32.55 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1704a6f949aff1d8101061645ede31ca96b572f8&tochange=78676939447ffd59eb7a265fbd78a384d30136ec

> 78676939447f	Matt Woodrow — Bug 1381753 - Recompute visible regions for ContainerLayers without intermediate surfaces when needed for invalidation. r=mstange

Comment 4

[Alice0775 White]

Attachment: bugAppearOnWin10.png

I can also reproduce the issue on Win10 Nightly62.0a1 x64.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

It seems likely that 63 is still affected though I was unable to reproduce the issue on MacOS 10.13.6.

Comment 7

[Darkspirit]

bug 1484412 comment 2 contains a different regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=89f8f948c2d1a582b82384543f24e9a69a051617&tochange=d5da77c1448183b938e263421b7ea4f679b8a944

Comment 8

[Kestrel]

I couldn't reproduce Bug 1484412 Comment 2 regression range on Ubuntu 18.04 and got the same one as in Comment 3.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix in 63. We could still take a patch for 65 or potentially for 64.

Comment 10

[Cameron McCormack (:heycam)]

I encountered this on another site today:

STR:

1. Open https://auspost.com.au/sending.
2. Mouse over one of the menu items such as "Receiving" or "Sending" towards the top of the page.
3. Notice that the popup menu doesn't get painted entirely.

I could only narrow down the regression range to a day's worth of pushes, but I suspect it's the same as this bug.

Comment 11

[Kestrel]

Both Comment 0 and Comment 10 examples render correctly for me with WebRender enabled on latest Nightly 66 (Ubuntu 18.10).

Comment 12

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1468728 - Don't try to maintain visible regions for Layers that might need to have a 3d representation. r?mstange

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c1c9564e962
Don't try to maintain visible regions for Layers that might need to have a 3d representation. r=miko

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8c1c9564e962

Comment 15

[Kestrel]

I can confirm that the Comment 0 and Comment 10 test cases are now rendering correctly with latest Nightly 69.0a1 (2019-05-28) (new profile, basic compositor) on Ubuntu 19.04.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider backporting to Beta ahead of the next ESR or can it ride the 69 trains?

Comment 17

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9063690 [details]
Bug 1468728 - Don't try to maintain visible regions for Layers that might need to have a 3d representation. r?mstange

Beta/Release Uplift Approval Request

• User impact if declined: Incorrect invalidation in some cases with transform-style:preserve-3d.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just changes preserve-3d (relatively rare) specific bits of the invalidation code, so has limited potential to cause regressions.
• String changes made/needed: None

Comment 18

[Julien Cristau [:jcristau]]

Comment on attachment 9063690 [details]
Bug 1468728 - Don't try to maintain visible regions for Layers that might need to have a 3d representation. r?mstange

I'd prefer to let this ride the trains