1468761 - Consider always serializing packed histogram snapshots

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Georg Fritzsche [:gfritzsche]]

Looking at e.g. bug 1467705, i notice that we don't never send out the unpacked representations.
I think that means that we effectively use two histogram serialization formats in the client, with one only being used on the client-side.

Can we just always use the packed representation and have the nsITelemetry snapshot function return this format?

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1468761 - Always serialize histograms in packed format

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1468761 - Migrate Telemetry tests to always assume packed histograms

Depends on D9235

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1468761 - Migrate external Telemetry tests to handle packed histograms

Depends on D9236

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65bfae07e0f4
Always serialize histograms in packed format r=chutten
https://hg.mozilla.org/integration/autoland/rev/9ee8406cf1d3
Migrate Telemetry tests to always assume packed histograms r=chutten
https://hg.mozilla.org/integration/autoland/rev/8c08dcec61d8
Migrate external Telemetry tests to handle packed histograms r=chutten

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for telemetry related xpcshell failures

backout: https://hg.mozilla.org/integration/autoland/rev/a67cc39bf78a77bd030cbb4a8ed1e5ce8e9c1baa


push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Csuccess%2Cretry%2Cusercancel%2Crunnable&searchStr=xpcshell&group_state=expanded&revision=8c08dcec61d8a3e5e234aacae1e2a373545bcdeb&selectedJob=207012781

example failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=207012781&repo=autoland&lineNumber=2565

task 2018-10-22T16:12:35.276Z] 16:12:35     INFO -  TEST-START | services/settings/test/unit/test_remote_settings_poll.js
[task 2018-10-22T16:12:36.102Z] 16:12:36  WARNING -  TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_remote_settings_poll.js | xpcshell return code: 0
[task 2018-10-22T16:12:36.103Z] 16:12:36     INFO -  TEST-INFO took 820ms
[task 2018-10-22T16:12:36.104Z] 16:12:36     INFO -  >>>>>>>
[task 2018-10-22T16:12:36.105Z] 16:12:36     INFO -  PID 18415 | JavaScript strict warning: resource://services-common/kinto-http-client.js, line 1796: ReferenceError: reference to undefined property "initializer"
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  PID 18415 | JavaScript strict warning: resource://services-common/kinto-http-client.js, line 1177: ReferenceError: reference to undefined property "initializer"
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  PID 18415 | JavaScript strict warning: resource://services-common/kinto-http-client.js, line 323: ReferenceError: reference to undefined property "initializer"
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  running event loop
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "initializer"" {file: "resource://services-common/kinto-http-client.js" line: 1796}]"
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "initializer"" {file: "resource://services-common/kinto-http-client.js" line: 1177}]"
[task 2018-10-22T16:12:36.111Z] 16:12:36     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "initializer"" {file: "resource://services-common/kinto-http-client.js" line: 323}]"

Comment 6

[Jan-Erik Rediger [:janerik]]

Code updated, new try run in progress: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a268f9f9ef3082d877e8c8d3100862cc6ee58795

Waiting for results and only pushing until everything is green.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6365c2181504
Always serialize histograms in packed format r=chutten
https://hg.mozilla.org/integration/autoland/rev/1774d920a170
Migrate Telemetry tests to always assume packed histograms r=chutten
https://hg.mozilla.org/integration/autoland/rev/76dccff8312e
Migrate external Telemetry tests to handle packed histograms r=chutten

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6365c2181504
https://hg.mozilla.org/mozilla-central/rev/1774d920a170
https://hg.mozilla.org/mozilla-central/rev/76dccff8312e