Closed Bug 1468770 Opened 3 years ago Closed 3 years ago

Periodic file updates should have an approval in the commit message

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set
normal

Tracking

(firefox-esr60 fixed, firefox61 fixed, firefox62 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: sfraser, Assigned: sfraser)

Details

Attachments

(2 files)

Add the command-line flag for a= and make sure the text in that field is appropriate.
Assignee: nobody → sfraser
Is the text 'repo-update' sufficient for the approval flag, or should it be something else?
Flags: needinfo?(ryanvm)
I've been using a=release so far, but repo-update also sounds fine.
Flags: needinfo?(ryanvm)
I'll update the old review expiry, too, while I'm at it.
Comment on attachment 8986137 [details]
Bug 1468770 repo-update submitter and commit msg r=ryanvm

Ryan VanderMeulen [:RyanVM] has approved the revision.

https://phabricator.services.mozilla.com/D1700
Attachment #8986137 - Flags: review+
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/faec64e8d578
repo-update submitter and commit msg r=RyanVM
https://hg.mozilla.org/mozilla-central/rev/faec64e8d578
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Looks like this needs "Name <email>" to be truly happy.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8986829 [details]
Bug 1468770 Update author for repo-update commits r=ryanvm

Ryan VanderMeulen [:RyanVM] has approved the revision.

https://phabricator.services.mozilla.com/D1753
Attachment #8986829 - Flags: review+
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47e6dedb5185
Update author for repo-update commits r=RyanVM
https://hg.mozilla.org/mozilla-central/rev/47e6dedb5185
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.