1468774 - Remove getPropertyDescriptor from CPOWs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Tom S. (please needinfo tschuster)]

Attachment: Remove getPropertyDescriptor from CPOWs

I want to totally remove the getPropertyDescriptor trap from Proxy/Wrapper. We could in theory already remove this trap from CPOWs and just rely on the base implementation. However I am just going to land this when we totally remove getPropertyDescriptor.

Comment 1

[Tom S. (please needinfo tschuster)]

I *think* we can land this, considering that we only use CPOWs for tests, we should be okay when it works on try. This try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad3edc8a0a7c3e857390a2c115819095f803ddc3&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified has quite  a bit of orange, but as far as I can tell most of them are known intermittent failures?

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Remove getPropertyDescriptor from CPOWs

Comment 3

[Tom S. (please needinfo tschuster)]

Comment on attachment 8996361 [details] [diff] [review]
Remove getPropertyDescriptor from CPOWs

I only need a review for removing GetPropertyDescriptor from sync-messages.ini

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8996361 [details] [diff] [review]
Remove getPropertyDescriptor from CPOWs

Review of attachment 8996361 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the sync-messages.ini change.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0d98b031aa
Remove getPropertyDescriptor from CPOWs. r=mrbkap r=mccr8

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fe0d98b031aa