Closed Bug 1468774 Opened 2 years ago Closed 2 years ago

Remove getPropertyDescriptor from CPOWs

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(2 files)

I want to totally remove the getPropertyDescriptor trap from Proxy/Wrapper. We could in theory already remove this trap from CPOWs and just rely on the base implementation. However I am just going to land this when we totally remove getPropertyDescriptor.
Assignee: nobody → evilpies
Attachment #8985397 - Flags: review?(mrbkap)
Attachment #8985397 - Flags: review?(mrbkap) → review+
I *think* we can land this, considering that we only use CPOWs for tests, we should be okay when it works on try. This try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad3edc8a0a7c3e857390a2c115819095f803ddc3&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified has quite  a bit of orange, but as far as I can tell most of them are known intermittent failures?
Comment on attachment 8996361 [details] [diff] [review]
Remove getPropertyDescriptor from CPOWs

I only need a review for removing GetPropertyDescriptor from sync-messages.ini
Attachment #8996361 - Flags: review?(continuation)
Comment on attachment 8996361 [details] [diff] [review]
Remove getPropertyDescriptor from CPOWs

Review of attachment 8996361 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the sync-messages.ini change.
Attachment #8996361 - Flags: review?(continuation) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0d98b031aa
Remove getPropertyDescriptor from CPOWs. r=mrbkap r=mccr8
https://hg.mozilla.org/mozilla-central/rev/fe0d98b031aa
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.