automatically copy headers when performing special "hidden" internal redirect to InterceptedHttpChannel

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P2
normal
RESOLVED FIXED
Last year
7 months ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

(Blocks 1 bug)

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

In e10s mode with parent-side intercept enabled we currently do a special internal redirect to the InterceptedHttpChannel.  This redirect is "hidden" from the child process to avoid confusing the legacy child-side intercept code.  An unfortunate consequence of this is that redirect handlers, like fetch API's, cannot do things like copy headers over to the new channel.

We should work around this by copying the headers over automatically for this one special redirect case.  Eventually this can be removed when the child-side intercept code is removed and the redirect is unhidden.
Comment on attachment 8985631 [details] [diff] [review]
Automatically copy headers to the InterceptedHttpChannel when performing the special hidden internal redirect. r=valentin

This patch copies non-standard headers to the InterceptedHttpChannel when do the special interception redirect in parent-side intercept mode.  Please see the comment in the patch for a longer explanation.
Attachment #8985631 - Flags: review?(valentin.gosu)
Priority: -- → P2
Attachment #8985631 - Flags: review?(valentin.gosu) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5ee1692bd3c
Automatically copy headers to the InterceptedHttpChannel when performing the special hidden internal redirect. r=valentin
https://hg.mozilla.org/mozilla-central/rev/d5ee1692bd3c
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Blocks: 1470234
You need to log in before you can comment on or make changes to this bug.