onBeforeRedirect with "responseHeaders" throws exception on internal/upgrade redirects

RESOLVED FIXED in Firefox -esr60

Status

defect
RESOLVED FIXED
Last year
Last year

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

(Blocks 1 bug)

58 Branch
mozilla62
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr6061+ fixed, firefox60 wontfix, firefox61+ fixed, firefox62+ fixed)

Details

Attachments

(1 attachment)

Bug 1462006 includes new API support for identifying redirect reasons.  I want to land and uplift just the actual fix now, that is what this bug is for.

Also re-requesting flags set on 1462006
Comment hidden (mozreview-request)

Comment 2

Last year
mozreview-review
Comment on attachment 8985470 [details]
Bug 1468830 ignore exceptions when retreiving response headers,

https://reviewboard.mozilla.org/r/251054/#review257310
Attachment #8985470 - Flags: review?(lgreco) → review+
Assignee

Comment 3

Last year
Comment on attachment 8985470 [details]
Bug 1468830 ignore exceptions when retreiving response headers,

Approval Request Comment
[Feature/Bug causing the regression]: internal or upgrade redirects cause a failure if a webextension listener requests response headers.  
[User impact if declined]: some extensions may break all extensions using onBeforeRedirect listeners
[Is this code covered by automated tests?]: bug 1462006 adds more extensive support for this including new tests.  This change itself is very simple. Existing tests would catch any general breakage.
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple try/catch patch
[String changes made/needed]: none
Attachment #8985470 - Flags: approval-mozilla-beta?

Comment 4

Last year
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e05d3484f97a
ignore exceptions when retreiving response headers, r=rpl

Comment 5

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/e05d3484f97a
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Please nominate this for Beta/ESR60 approval when you get a chance.
Flags: needinfo?(mixedpuppy)
Comment on attachment 8985470 [details]
Bug 1468830 ignore exceptions when retreiving response headers,

Fixes extension bustage when onBeforeRedirect listeners are used. Approved for 61.0rc1 and ESR 60.1.
Flags: needinfo?(mixedpuppy)
Attachment #8985470 - Flags: approval-mozilla-esr60+
Attachment #8985470 - Flags: approval-mozilla-beta?
Attachment #8985470 - Flags: approval-mozilla-beta+

Updated

Last year
Product: Toolkit → WebExtensions

Updated

Last year
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.