Bug 1462006 includes new API support for identifying redirect reasons. I want to land and uplift just the actual fix now, that is what this bug is for. Also re-requesting flags set on 1462006
Comment on attachment 8985470 [details] Bug 1468830 ignore exceptions when retreiving response headers, https://reviewboard.mozilla.org/r/251054/#review257310
Attachment #8985470 - Flags: review?(lgreco) → review+
Comment on attachment 8985470 [details] Bug 1468830 ignore exceptions when retreiving response headers, Approval Request Comment [Feature/Bug causing the regression]: internal or upgrade redirects cause a failure if a webextension listener requests response headers. [User impact if declined]: some extensions may break all extensions using onBeforeRedirect listeners [Is this code covered by automated tests?]: bug 1462006 adds more extensive support for this including new tests. This change itself is very simple. Existing tests would catch any general breakage. [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: simple try/catch patch [String changes made/needed]: none
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/e05d3484f97a ignore exceptions when retreiving response headers, r=rpl
Assignee: nobody → mixedpuppy
status-firefox60: affected → wontfix
status-firefox-esr60: --- → affected
tracking-firefox61: ? → +
tracking-firefox62: --- → +
tracking-firefox-esr60: ? → 61+
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox62: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Please nominate this for Beta/ESR60 approval when you get a chance.
Comment on attachment 8985470 [details] Bug 1468830 ignore exceptions when retreiving response headers, Fixes extension bustage when onBeforeRedirect listeners are used. Approved for 61.0rc1 and ESR 60.1.
status-firefox61: affected → fixed
status-firefox-esr60: affected → fixed
You need to log in before you can comment on or make changes to this bug.