Closed Bug 1468860 Opened 5 years ago Closed 5 years ago

Rename a few error-message constants to fix s/REGEP/REGEXP/ typos

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Patch
4.32 KB, patch
sfink
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch Patch — — Splinter Review 

        Attachment #8985523 -
        Flags: review?(sphink)

    
    

    
  
Comment on attachment 8985523 [details] [diff] [review]
Patch

Review of attachment 8985523 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/js.msg
@@ -517,5 @@
>  MSG_DEF(JSMSG_NEWREGEXP_FLAGGED,       0, JSEXN_TYPEERR, "can't supply flags when constructing one RegExp from another")
>  MSG_DEF(JSMSG_NOTHING_TO_REPEAT,       0, JSEXN_SYNTAXERR, "nothing to repeat")
>  MSG_DEF(JSMSG_NUMBERS_OUT_OF_ORDER,    0, JSEXN_SYNTAXERR, "numbers out of order in {} quantifier.")
>  MSG_DEF(JSMSG_RANGE_WITH_CLASS_ESCAPE, 0, JSEXN_SYNTAXERR, "character class escape cannot be used in class range in regular expression")
> -MSG_DEF(JSMSG_RAW_BRACE_IN_REGEP,      0, JSEXN_SYNTAXERR, "raw brace is not allowed in regular expression with unicode flag")

I would prefer doubling down and calling this JSMSG_AW_BACE_IN_REGEP instead, but I suppose your way is fine too.

creat(2) foreve!

        Attachment #8985523 -
        Flags: review?(sphink) → review+

    
    

    
  
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8eb78d6b65d
Rename a few error-message constants to fix s/REGEP/REGEXP/ typos.  r=sfink

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d8eb78d6b65d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago

          status-firefox62:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62

          You need to log in
          before you can comment on or make changes to this bug.