1468860 - Rename a few error-message constants to fix s/REGEP/REGEXP/ typos

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8985523 [details] [diff] [review]
Patch

Review of attachment 8985523 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/js.msg
@@ -517,5 @@
>  MSG_DEF(JSMSG_NEWREGEXP_FLAGGED,       0, JSEXN_TYPEERR, "can't supply flags when constructing one RegExp from another")
>  MSG_DEF(JSMSG_NOTHING_TO_REPEAT,       0, JSEXN_SYNTAXERR, "nothing to repeat")
>  MSG_DEF(JSMSG_NUMBERS_OUT_OF_ORDER,    0, JSEXN_SYNTAXERR, "numbers out of order in {} quantifier.")
>  MSG_DEF(JSMSG_RANGE_WITH_CLASS_ESCAPE, 0, JSEXN_SYNTAXERR, "character class escape cannot be used in class range in regular expression")
> -MSG_DEF(JSMSG_RAW_BRACE_IN_REGEP,      0, JSEXN_SYNTAXERR, "raw brace is not allowed in regular expression with unicode flag")

I would prefer doubling down and calling this JSMSG_AW_BACE_IN_REGEP instead, but I suppose your way is fine too.

creat(2) foreve!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8eb78d6b65d
Rename a few error-message constants to fix s/REGEP/REGEXP/ typos.  r=sfink

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d8eb78d6b65d