Comment on attachment 8987992 [details] Bug 1468865 - Port raptor firefox tp6 to win; https://reviewboard.mozilla.org/r/253256/#review259828 just small nits ::: taskcluster/ci/test/raptor.yml:35 (Diff revision 1) > try-name: raptor-firefox-tp6 > treeherder-symbol: Rap(tp6) > run-on-projects: > by-test-platform: > macosx.*: ['try', 'mozilla-central'] > - linux64.*: ['try', 'mozilla-central'] > + default: ['try', 'mozilla-central'] if this is the default, why do we have macosx.* here? ::: testing/raptor/raptor/playback/mitmproxy.py:166 (Diff revision 1) > + cmd = [python3_path, '--version'] > + # just want python3 ver printed in production log > + subprocess.Popen(cmd, env=os.environ.copy()) > + return python3_path > + > + def setup_py3_virtualenv(self): this is a lot of custom code just for windows. Is there a chance we could push to get python3 installed by default on windows? If we did that would most of this go away? If so, lets file a bug, land this stuff, and then when python3 is available by default we can clean up our code here. ::: testing/raptor/raptor/raptor.py:46 (Diff revision 1) > > def __init__(self, app, binary, run_local=False, obj_path=None): > self.config = {} > self.config['app'] = app > self.config['binary'] = binary > - self.config['platform'] = mozinfo.os > + self.config['platform'] = mozinfo.os + "_" + mozinfo.processor how does this work for 32 and 64 bit? This seems to change everything for linux/osx as well.

Attachment #8987992 - Flags: review?(jmaher) → review+

Robert Wood [:rwood]

Assignee

Comment 4

•

7 years ago

mozreview-review-reply

Comment on attachment 8987992 [details] Bug 1468865 - Port raptor firefox tp6 to win; https://reviewboard.mozilla.org/r/253256/#review259828 Thanks for the review! It runs locally on my Win 10 test machine however I see it is failing on try, an import issue or something, which I will look into. > if this is the default, why do we have macosx.* here? Taskcluster decision graph fails if you just have a 'default', you need at least one other platform specified. > this is a lot of custom code just for windows. Is there a chance we could push to get python3 installed by default on windows? If we did that would most of this go away? > > If so, lets file a bug, land this stuff, and then when python3 is available by default we can clean up our code here. Yeah it's a bit of a nightmare setting up the py3 virtualenv for mitmproxy (same as on talos too). That's a great idea, I filed Bug 1471611. > how does this work for 32 and 64 bit? This seems to change everything for linux/osx as well. Yeah so 'platform' instead of just 'win' is now 'win_x86_x64' (or 32). The code just checks if 'win' in 'platform' etc, but maybe it's best to separate it anyway - I'll add a self.config['processor'] key instead to store x64 or x32. Thanks!

Joel Maher ( :jmaher ) (UTC -8)

Comment 5

•

7 years ago

we can simplify it to remove the default and put it on a single line.

Robert Wood [:rwood]

Assignee

Comment 6

•

7 years ago

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #5) > we can simplify it to remove the default and put it on a single line. Ah right yes! We don't even need it by platform.

Robert Wood [:rwood]

Assignee

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03f64861147e0dc7784471225070a7ce29f49ed2

Robert Wood [:rwood]

Assignee

Comment 19

•

7 years ago

Update: Raptor tp6 on Windows now works - except for the problem on windows when shutting down raptor (all raptor tests). I've filed Bug 1471908 for that. Since tp6 win does work (except for that) and this is tier 3 I'm going to go ahead and land this anyway.

Robert Wood [:rwood]

Assignee

Comment 20

•

7 years ago

(In reply to Robert Wood [:rwood] from comment #19) > Update: Raptor tp6 on Windows now works - except for the problem on windows > when shutting down raptor (all raptor tests). I've filed Bug 1471908 for shutting down * Firefox *

Comment hidden (mozreview-request)

Pulsebot

Comment 22

•

7 years ago

Pushed by rwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc00d5a02ec2 Port raptor firefox tp6 to win; r=jmaher

Eliza Balazs [:ebalazs_]

Comment 23

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/cc00d5a02ec2

Status: ASSIGNED → RESOLVED

Closed: 7 years ago

status-firefox63: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla63

You need to log in before you can comment on or make changes to this bug.