Closed Bug 1468946 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11525 - ES Modules: Set referrer for top-level module script in ModuleScriptLoader

Categories

(Core :: DOM: Workers, enhancement, P4)

Product:
Core
Component:
DOM: Workers
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11525 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11525
Details from upstream follow.

Hiroki Nakagawa <nhiroki@chromium.org> wrote:
>  ES Modules: Set referrer for top-level module script in ModuleScriptLoader
>  
>  Before this CL, referrer for top-level module script is set in
>  BaseFetchContext::AddAdditionalRequestHeaders() using
>  ExecutionContext::GetOutgoingReferrer(). This works for documents, but doesn't
>  for workers because this execution context is corresponding to "module map
>  settings object", not "fetch client settings object".
>  
>  To fix this, this CL sets the referrer for top-level module script using "fetch
>  client settings object" in ModuleScriptLoader as the spec defines.
>  
>  Change-Id: I0878b13febdae4ee2dc56c998e7f2c100e9c1ba7
>  Bug: 842553
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1102236
>  WPT-Export-Revision: 53bb9fdd42f0fc44b27f2e7dfc263312633d052e
Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 11525 applied with additional changes from upstream: 4b4c626fc8602d1d06680a7d298789708fae5cd3, ed2f4a4d980a609e817b4115d025cd06202a9882
Component: web-platform-tests → DOM: Workers
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 15 subtests
TIMEOUT: 2
NOTRUN : 14

New tests that have failures or other problems:
/workers/modules/dedicated-worker-import-referrer.html: TIMEOUT
    Cross-origin dynamic import with "no-referrer" referrer policy.: NOTRUN
    Cross-origin dynamic import with "origin" referrer policy.: NOTRUN
    Cross-origin dynamic import with "same-origin" referrer policy.: NOTRUN
    Cross-origin static import with "no-referrer" referrer policy.: NOTRUN
    Cross-origin static import with "origin" referrer policy.: NOTRUN
    Cross-origin static import with "same-origin" referrer policy.: NOTRUN
    Same-origin dynamic import with "no-referrer" referrer policy.: NOTRUN
    Same-origin dynamic import with "origin" referrer policy.: NOTRUN
    Same-origin dynamic import with "same-origin" referrer policy.: NOTRUN
    Same-origin static import with "no-referrer" referrer policy.: NOTRUN
    Same-origin static import with "origin" referrer policy.: NOTRUN
    Same-origin static import with "same-origin" referrer policy.: NOTRUN
    Same-origin top-level module script loading with "no-referrer" referrer policy: TIMEOUT
    Same-origin top-level module script loading with "origin" referrer policy: NOTRUN
    Same-origin top-level module script loading with "same-origin" referrer policy: NOTRUN
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aaf66fd7660f
[wpt PR 11525] - ES Modules: Set referrer for top-level module script in ModuleScriptLoader, a=testonly
https://hg.mozilla.org/mozilla-central/rev/aaf66fd7660f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.