Closed Bug 1469003 Opened Last year Closed Last year

Convert SegmentedVector to use a manually aligned |unsigned char| array for storage

Categories

(Core :: MFBT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
Attachment #8985658 - Flags: review?(nfroyd)
Comment on attachment 8985658 [details] [diff] [review]
Patch

Review of attachment 8985658 [details] [diff] [review]:
-----------------------------------------------------------------

*shrug* sure.  How does this differ in practice from the previous code?  Just more C++11-y?
Attachment #8985658 - Flags: review?(nfroyd) → review+
General cleanliness mostly.  But it also has mild benefit for marking the memory as initialized-later, because you can just tack such attribute, if ever we get one, on the field without wondering whether it goes on the union or the particular arm or whatever.
...oh, there already is such attribute.  I'll add MOZ_INIT_OUTSIDE_CTOR before landing.
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a61ae45785b0
Convert SegmentedVector to use a manually aligned |unsigned char| array for storage, using a clean C++11 idiom.  r=froydnj
https://hg.mozilla.org/mozilla-central/rev/a61ae45785b0
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.