1469006 - Replace some script->compartment() calls with script->realm()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jan de Mooij [:jandem]]

Scripts are tied to a specific realm so things like CanReuseScriptForClone need to check the realm instead of the compartment.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Replace some script->compartment() calls with script->realm()

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8985660 [details] [diff] [review]
Replace some script->compartment() calls with script->realm()

Review of attachment 8985660 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.  Maybe worth removing JSScript::compartment() so people naturally default to realm()?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1b6b50a1b9a
Replace some script->compartment() calls with script->realm(). r=luke

Comment 4

[Jan de Mooij [:jandem]]

(In reply to Luke Wagner [:luke] from comment #2)
> Maybe worth removing JSScript::compartment() so people
> naturally default to realm()?

That might be a good idea. It's not entirely trivial though because we have some templated thing->compartment() calls..

https://searchfox.org/mozilla-central/rev/93d2b9860b3d341258c7c5dcd4e278dea544432b/js/src/gc/Tracer.cpp#152

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f1b6b50a1b9a