Closed Bug 1469019 Opened 2 years ago Closed Last year

Implement Object.fromEntries

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Attachment #8985674 - Attachment description: Implement Object.fromEntries → Implement Object.fromEntries (WIP patch, no tests)
Priority: -- → P3
Promoted to Stage 3.
Attachment #8985674 - Attachment is obsolete: true
Depends on: 1483380
Attached patch Object.fromEntries (obsolete) — Splinter Review
Attachment #9001282 - Flags: review?(evilpies)
Comment on attachment 9001282 [details] [diff] [review]
Object.fromEntries

Review of attachment 9001282 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/Object.js
@@ +293,5 @@
> +    // We omit the usual step number comments here because they don't help.
> +    // This implementation inlines AddEntriesFromIterator and
> +    // CreateDataPropertyOnObject, so it looks more like the polyfill
> +    // <https://github.com/tc39/proposal-object-from-entries/blob/master/polyfill.js>
> +    // than the spec algorithm.

I agree.
Attachment #9001282 - Flags: review?(evilpies) → review+
hooray! code LGTM too. what's the likely soonest this might ride a release train?
Comment on attachment 9001282 [details] [diff] [review]
Object.fromEntries

Review of attachment 9001282 [details] [diff] [review]:
-----------------------------------------------------------------

Andrew: Pursuant to js/xpconnect/tests/chrome/test_xrayToJS.xul,

    A property on the Object constructor has changed! You need a security audit from an XPConnect peer

which is you. This seems hardly necessary in this case, but why not.
Attachment #9001282 - Flags: review?(continuation)
Attachment #9001762 - Flags: review?(continuation)
Attachment #9001282 - Attachment is obsolete: true
Attachment #9001282 - Flags: review?(continuation)
Comment on attachment 9001762 [details] [diff] [review]
Object.fromEntries

Carrying forward evilpie's review.
Attachment #9001762 - Flags: review+
Comment on attachment 9001762 [details] [diff] [review]
Object.fromEntries

Review of attachment 9001762 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really qualified to audit Xray stuff. Maybe Peter could review.
Attachment #9001762 - Flags: review?(continuation) → review?(peterv)
Comment on attachment 9001762 [details] [diff] [review]
Object.fromEntries

Review of attachment 9001762 [details] [diff] [review]:
-----------------------------------------------------------------

This looks ok to me.
Attachment #9001762 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/ed3c662bb21d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.