Closed
Bug 1469029
Opened 7 years ago
Closed 7 years ago
Support selected CSS rules for the Add-ons zone
Categories
(developer.mozilla.org Graveyard :: General, enhancement, P1)
developer.mozilla.org Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wbamberg, Assigned: rjohnson)
Details
(Keywords: in-triage, Whiteboard: [points=1])
When we remove zones, we will also remove the zone CSS. In most cases this is fine, but there are a few cases where we probably still want to be able to use the zone styles.
In the Add-ons zone, there are a couple of useful rules. I *don't* think we have to block zone removal on these, but it would be great to have these rules or some version of them reinstated in the common Kuma CSS.
## reference-values
dd > dl.reference-values {
padding-left: 40px;
}
This lets us give an extra indent to a dl, when it's embedded inside another dl, which comes up sometimes in the reference pages. The extra indent people understand that the embedded dl is part of an embedded list and is not part of the main list.
Compare:
https://screenshots.firefox.com/XTIi9NuEJL1rZj2G/developer.mozilla.org (with this class)
https://screenshots.firefox.com/Tel4DbD7GnV8Gt49/developer.mozilla.org (without this class)
## webextension-api-sidebar
li.webextension-api-sidebar {
background-color: #f4f7f8;
}
This applies a background color to the piece of a sidebar containing the api items relevant to the current page. It helps people orient themselves in the sidebar:
Compare:
https://screenshots.firefox.com/MklnzMOR4g3oOk0o/developer.mozilla.org (with this class)
https://screenshots.firefox.com/gS4tI3cWCSuXhHGI/developer.mozilla.org (without this class)
Updated•7 years ago
|
Updated•7 years ago
|
Assignee: nobody → rjohnson
Status: NEW → ASSIGNED
Comment 1•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma
https://github.com/mozilla/kuma/commit/f752a9d01dba6a9641bd68aa6d3a1d8e01abc1e4
bug 1469029: keep two zone-related css classes
https://github.com/mozilla/kuma/commit/ba55c251dcb35a08ba38398ccfe037ccfbf6ae17
bug 1469029: add utility classes and further comments
https://github.com/mozilla/kuma/commit/a99236a55f019ee85ef7a4dcd47dab0b745eb1d1
bug 1469029: fix stylelint error
https://github.com/mozilla/kuma/commit/4d01ad4fb6636b92c5bf92e378c1182514550176
Merge pull request #4858 from escattone/keep-two-zone-related-css-classes-1469029
bug 1469029: keep two zone-related css classes
Assignee | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•