Closed
Bug 1469043
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11535 - Floats and out-of-flow objects may not be adjacent to anonymous blocks.
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11535 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11535 Details from upstream follow. Morten Stenshorne <mstensho@chromium.org> wrote: > Floats and out-of-flow objects may not be adjacent to anonymous blocks. > > Floats and out-of-flow objects need to be true layout siblings of the > inlines, or rendering will be wrong. This means that such objects should > never be siblings of anonymous blocks, but rather inside them. This > already works correctly for initial layout tree building, and also for > many DOM manipulations. However, code was missing to satisfy this > requirement if we removed a regular block that was a sibling of an > anonymous block and either a float or out-of-flow positioned object. > > This even caused a crash triggered by ruby code, which ended up mixing > inline and block children within the same container. That is not > allowed. This happened in the MoveAllChildrenIncludingFloatsTo() call > inside LayoutRubyBase::MoveBlockChildren(). Added a DCHECK to > MoveAllChildrenIncludingFloatsTo() (which could fail prior to this fix); > When moving children from one container to another, either both or none > of the containers must have inline children. > > Bug: 852640 > Change-Id: I51d3de12c73ddd07d6b4c1aa55221b4f92359ca7 > > Reviewed-on: https://chromium-review.googlesource.com/1102690 > WPT-Export-Revision: 302b59d08717d11aa2b502675fc10d5b98422132
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b700497259f9d95901492f5521297284fd90152
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4001141eb8e7075fdb4752b2a6872947ba2a5aa
Assignee | ||
Comment 3•6 years ago
|
||
Ran 2 tests PASS : 2
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/50c66d30e5b3 [wpt PR 11535] - Floats and out-of-flow objects may not be adjacent to anonymous blocks., a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/50c66d30e5b3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•